[#8230] - Solve word count bug in mod_feed + some code review
- Closed
- 8 May 2016
- Medium
- Build: staging
- Easy Test
- # 8230
- Diff
- n9iels:mod_feed
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
About this PR
This PR solves a bug with the word count parameter of mod_feed. If you load a feed with HTML tags (for example: http://community.joomla.org/blogs/community.feed?type=rss) and set the word count to 20 there are way less than 20 words visible. The two things that cause this problem:
-
JHtml::_('string.truncate')counts the characters, not the words of the string - HTML tags like
<a href="http://link.nl">are counted too
This PR change the text of the parameter to Character count and I also adds strip_tags() for the character count.
Other changes in this PR are code style and some change to make the code more readably and logic.
Test instructions
- Make a mod_feed module and use http://community.joomla.org/blogs/community.feed?type=rss as Feed URL, set the RTL Feed paramter on "No" and all other parameters on "Yes" for now
- Set the "Word count" parameter on 20, and confirm the feed displays less than 20 words on the front-end
- Apply the patch, and confirm the parameter is now called "Character limit" and the amount of characters is better now (Maybe still not 20 characters, because the function don't cut words in half)
- Confirm all parameters are working like they use to do
- Install an RTL language (Persion for example), and test the "RTL Feed" parameter for this language. If "RTL Feed" is set to no, even on RTL languages the feed must be displayed LTR
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
zero-24
- | Category | ⇒ | Front End RTL |
| Labels | |||
| Easy | No | ⇒ | Yes |
This PR has received new commits.
CC: @Ruchiranga
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8230.
This PR has received new commits.
CC: @Ruchiranga
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8230.
@Ruchiranga Thanks for testing! Yes you're right, the RTL function wasn't working, I used a wrong variable. I also changed the label of the parameter to Character limit, that is a better label indeed.
Can you please test again, and confirm the problems are solved?
I have tested this item 
successfully on 607a440
* The amount of characters shown has become better. See
Before applying the patch and
After applying the patch.
- All other parameters including "RTL Feed" work the way they should.
- The parameter is now called "Character limit"
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8230.
I´m not sure if this breaks something on existing sites because even if the wordcount didn´t work right before
i don´t know if we can just change it to character limit?
Isn´t it better to fix the wordcount instead?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8230.
Changing from word count to character count will break peoples sites. Imagine I have it set to 10
before
my news feed of approximately ten words excepting html bug
after
my news fe
So with this change form word to character count it cannot be accepted.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8230.
| Status | Pending | ⇒ | Information Required |
| Labels | |||
If you want to update the PR to retain the word count then this can be tested otherwise I am afraid it will have to be closed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8230.
| Labels | |||
| Category | Front End RTL | ⇒ | Front End Language & Strings RTL |
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 09:39:03 |
| Closed_By | ⇒ | brianteeman |
Closed for the reason above
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8230.
| Labels | |||
I have tested this item
unsuccessfully on 61f6253
### Tested successfully
Tested unsuccessfully
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8230.