? ? Success

User tests: Successful: Unsuccessful:

avatar marijkestuivenberg
marijkestuivenberg
12 Oct 2015

This change applies to all components that use com_categories except for User Notes.
It adds more consistency to the Title when adding a new category or when editing a category.

Currently when a category is added or when a category is edited, the title puls the strings from en-GB.com_categories.ini. Except when a categories in Articles is edited, it shows a string that is currently in en-GB.com_content.ini though the constant of that one is COM_CATEGORIES_CATEGORY_EDIT_TITLE which indicates it should be in en-GB.com_categories.ini

In the latter file this constant already exists and shows the Titles on the respective views:
Category Manager: Add A New %s Category
Category Manager: Edit A New %s Category
Where %s is the components name (e.g Category Manager: Add A New Banners Category
Category Manager: Edit A New Banners Category)
The use of Manager is however deprecated, and should be changed.
This patch changes the strings into:
%s: New Category and %s: Edit Category where %s is the components name.

To test:
View the Titles in the pages where categories can be added and edited before applying the patch:
Articles -> Categories:
Click New - The title shows "Category Manager: Add A New Articles Category"
Edit a category by either clicking on the title or check the check box and click on Edit in the toolbar - The title shows: "Article: Edit Category"

Banners -> Categories:
Click New - Title shows "Category Manager: Add A New Banners Category"
Edit a category by either clicking on the title or check the check box and click on Edit in the toolbar - The title shows: "Category Manager: Edit A New Banners Category"

This applies also to the Category views in Contacts, News Feeds, and Web Links with the comment that Banners is replaced by Contacts, News Feeds, and Web Links in the respective views of those components.

After applying the patch each of the above view shows the title:
Articles: Edit Category *
Articles: New Category *
(*) Articles is replaced by Banners, Contacts, News Feeds, and Web Links in the respective views of those components.

For consistency I also changed COM_CATEGORIES_CATEGORIES_BASE_TITLE="Category Manager" into COM_CATEGORIES_CATEGORIES_BASE_TITLE="Categories"

avatar marijkestuivenberg marijkestuivenberg - open - 12 Oct 2015
avatar marijkestuivenberg marijkestuivenberg - change - 12 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Oct 2015
Labels Added: ? ?
avatar zero-24 zero-24 - change - 12 Oct 2015
Easy No Yes
avatar zero-24 zero-24 - change - 12 Oct 2015
Category Language & Strings UI/UX
avatar YouriiM26 YouriiM26 - test_item - 12 Oct 2015 - Tested successfully
avatar YouriiM26
YouriiM26 - comment - 12 Oct 2015

I have tested this item :white_check_mark: successfully on 6839adf

Patch worked for me!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8070.

avatar infograf768 infograf768 - test_item - 12 Oct 2015 - Tested successfully
avatar infograf768
infograf768 - comment - 12 Oct 2015

I have tested this item :white_check_mark: successfully on 6839adf

OK here.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8070.

avatar zero-24
zero-24 - comment - 12 Oct 2015

@brianteeman Any points here? Else we can RTC :)

Thanks.

avatar zero-24 zero-24 - change - 20 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 20 Oct 2015
Milestone Added:
Status Pending Ready to Commit
Labels
avatar zero-24
zero-24 - comment - 20 Oct 2015

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8070.

avatar joomla-cms-bot joomla-cms-bot - change - 20 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - reference | 0cd99a8 - 20 Oct 15
avatar rdeutz rdeutz - merge - 20 Oct 2015
avatar rdeutz rdeutz - close - 20 Oct 2015
avatar rdeutz rdeutz - change - 20 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-20 15:42:47
Closed_By rdeutz
avatar zero-24 zero-24 - change - 20 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment