[#7975] - Removed Else statement from getUserStateFromRequest
- Closed
- 10 Jan 2016
- Medium
- Build: staging
- # 7975
- Diff
- Mathewlenning:CLEANING-JApplicationCms
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Very simple change
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
Disagree with this change. Don't mind removing use of variable, do mind setting user state regardless whether it was changed in the request. Would prefer it not be set unneeded or change the comment to reflect what is done in code!
Actually NoNumber presented a better refactor that keep the signature and side effects the same as before. I'll update it when I get back to my desk.
Sincerely,
Mathew Lenning
P.S. This message was sent via iPhone, so please forgive any errors
On Oct 8, 2015, at 7:17 PM, sovainfo notifications@github.com wrote:
Disagree with this change. Don't mind removing use of variable, do mind setting user state regardless whether it was changed in the request. Would prefer it not be set unneeded or change the comment to reflect what is done in code!
―
Reply to this email directly or view it on GitHub.
This PR has received new commits.
CC: @n9iels
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7975.
Not using the variable $cur_state would be an quality improvement and more efficient.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-10 13:49:23 |
| Closed_By | ⇒ | wilsonge |
Merged on review - thanks Mathew!
| Milestone |
Added: |
||
I have tested this item
successfully on 81750b1
Looks good to me
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7975.