? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Jul 2015

Hopefully the screenshots show the proposed changes of this PR

Advanced Mode - Default

Before

advanced-mode-old

After

advanced-mode-new

rvlq

Extended Mode (enable in the plugin)

Before

extended-mode-old

After

extended-mode-new

extended-mode-new - small

[Note this cant be tested with #7170 as it needs a small update to match the changes there]

avatar brianteeman brianteeman - open - 31 Jul 2015
avatar brianteeman brianteeman - change - 31 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 31 Jul 2015
Category Plugins UI/UX
avatar zero-24 zero-24 - change - 31 Jul 2015
Easy No Yes
avatar brianteeman
brianteeman - comment - 31 Jul 2015

@dgt41 your last recommendation made Travis sad. I dont know the best way to make Travis happy again

avatar dgt41
dgt41 - comment - 31 Jul 2015

Arrrg, the last edit exceeds the allowed characters per line. But don’t try to do anything I will make a PR here shortly to sort this out

avatar brianteeman
brianteeman - comment - 31 Jul 2015

I am not trying to do anything.

3261939 31 Jul 2015 avatar dgt41 CS
avatar dgt41
dgt41 - comment - 31 Jul 2015
avatar brianteeman
brianteeman - comment - 31 Jul 2015

@dgt41 merged

avatar crystalenka crystalenka - test_item - 30 Sep 2015 - Tested successfully
avatar crystalenka
crystalenka - comment - 30 Sep 2015

I have tested this item :white_check_mark: successfully on 032f4f4


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7593.

avatar nikosdion nikosdion - test_item - 1 Oct 2015 - Tested successfully
avatar nikosdion
nikosdion - comment - 1 Oct 2015

I have tested this item :white_check_mark: successfully on 032f4f4
It is common sense and looks SO MUCH BETTER in limited width environments (narrow windows, double column edit pages, mobile phones etc). +1 from me.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7593.

avatar brianteeman brianteeman - change - 1 Oct 2015
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 1 Oct 2015

Thanks for testing - setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7593.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 1 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 1 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 1 Oct 2015
Milestone Removed:
avatar roland-d
roland-d - comment - 24 Oct 2015

@dgt41 This PR conflicts with your other PR #7170 which is merged. Can you check how this relates to your PR and if it is still applicable? Thanks.

avatar brianteeman
brianteeman - comment - 24 Oct 2015

where is the conflict - github isnt showing it to me

Unless @dgt41 changed his PR then it should be fine as it was tested with it

avatar roland-d
roland-d - comment - 24 Oct 2015

@brianteeman The conflict is not shown here because the PR is against staging and I am going to merge it into the 3.5-dev branch. In the 3.5-dev branch another Tiny PR by @dgt41 has already been merged.

The conflict is here:
This PR:
https://github.com/joomla/joomla-cms/pull/7593/files#diff-d93fcfa294cc59e70963805efe9f303bR619

Other PR:
https://github.com/joomla/joomla-cms/pull/7170/files#diff-d93fcfa294cc59e70963805efe9f303bR625

same lines have been changed.

avatar brianteeman
brianteeman - comment - 24 Oct 2015

Ah ok - thanks checking against 3.5-dev now the patch is still needed but it does indeed conflict and revert the changes made by @dgt41 in #7170

Rebasing this PR is beyond my skillset (I never get it right) so can someone do a PR against my branch to update it - its a simple update - thanks

avatar roland-d
roland-d - comment - 24 Oct 2015

@brianteeman a rebase is not needed, if @dgt41 can do a PR against your branch we should be good to go. Thanks.

avatar brianteeman
brianteeman - comment - 24 Oct 2015

I meant have used the wrong terminology ;)

On 24 October 2015 at 12:09, RolandD notifications@github.com wrote:

@brianteeman https://github.com/brianteeman a rebase is not needed, if
@dgt41 https://github.com/dgt41 can do a PR against your branch we
should be good to go. Thanks.


Reply to this email directly or view it on GitHub
#7593 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar dgt41
dgt41 - comment - 24 Oct 2015

@brianteeman this pr is against staging the conflict comes with #7170 which is merged in 3.5-dev. I think if you rebadge this against 3.5-Dev then the conflict will be revealed

avatar roland-d
roland-d - comment - 24 Oct 2015

@dgt41 Brian doesn't know how to rebase against 3.5-dev. My question is, can you provide a PR against this branch that solves the conflicts?

avatar brianteeman
brianteeman - comment - 25 Oct 2015

Looks like the PR @dgt41 did on ym repo just broke it even more

avatar zero-24
zero-24 - comment - 26 Oct 2015

Closing as we have a new PR here #8159

avatar zero-24 zero-24 - change - 26 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-26 05:58:32
Closed_By zero-24
avatar zero-24 zero-24 - close - 26 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 26 Oct 2015
avatar zero-24 zero-24 - close - 26 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2015
Labels Removed: ?
avatar brianteeman brianteeman - head_ref_deleted - 26 Oct 2015
avatar roland-d roland-d - reference | 1e20d6a - 2 Nov 15
avatar roland-d roland-d - reference | 5e6596c - 2 Nov 15

Add a Comment

Login with GitHub to post a comment