Feeling Lucky
?
[#7457] - Php7 tests
- Closed
- 17 Jul 2015
- Medium
- Build: staging
- # 7457
- Diff
- nibra:php7-tests
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The test suite is currently failing on PHP7. This PR fixes the issues reported by Travis.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
nibra
- comment
- 17 Jul 2015
Ok! Is theproblem with the framework's String class solved, too? That name is not allowed in PHP7. I propose to rename it to Utf8String.
mbabker
- comment
- 17 Jul 2015
We renamed it to StringHelper in the Framework (see joomla-framework/string@a1f9506) and changed the legacy JString to directly extend from that versus the now disallowed named class.
nibra
- comment
- 17 Jul 2015
Very good. Then this PR is of no use; I'm closing it.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-17 22:46:32 |
| Closed_By | ⇒ | nibra |
We have PHP 7 compat issues dealt with in the
3.5-devbranch (where things are passing with flying colors).