Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7455] - Refactored router tests

? Success

User tests: Successful: Unsuccessful:

avatar nibra
nibra
17 Jul 2015
  • less assertions per test
  • speaking names for most test methods
  • test JRouter instead of JUri
  • use Reflection instead of mocks to test internals
avatar nibra nibra - open - 17 Jul 2015
avatar nibra nibra - change - 17 Jul 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2015
Labels Added: ?
avatar wilsonge
wilsonge - comment - 17 Jul 2015

Couple of small comments - but overall looks really awesome :) ty!

avatar nibra
nibra - comment - 17 Jul 2015

Fixed the issues, you found, George.

avatar wilsonge
wilsonge - comment - 17 Jul 2015

Awesome. I've pinged @mbabker just to make sure I haven't missed anything. And will merge as soon as he gives the goahead :)

avatar mbabker
mbabker - comment - 17 Jul 2015

Don't wait for me, I'm conferencing this weekend and still owe another team a review/merge on production code.

avatar wilsonge wilsonge - reference | fe56f94 - 17 Jul 15
avatar wilsonge wilsonge - merge - 17 Jul 2015
avatar wilsonge wilsonge - close - 17 Jul 2015
avatar wilsonge wilsonge - change - 17 Jul 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-07-17 22:26:34
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 17 Jul 2015
avatar nibra nibra - head_ref_deleted - 17 Jul 2015
avatar zero-24 zero-24 - change - 27 Jul 2015
Milestone Added:

Add a Comment

Login with GitHub to post a comment