? Success

User tests: Successful: Unsuccessful:

avatar geejay101
geejay101
7 Jun 2015

this pull request replaces http://issues.joomla.org/tracker/joomla-cms/7131

Problem:

It is not possible to create admin groups which have the ability to deactivate / activate other users, but not change any other user rights. An administrator/user with only EditState permission for the Administration User component cannot deactivate / activate other users. When clicking on block/unblock in the userlist, the status of the user doesnt change.

The problem occurs because the tick-boxes in the userlist are not shown when the administrator has only EditState permission. The tickbox is only shown when the administrator has also Edit permission.

Solution:
administrator/components/com_users/views/users/tmpl/default.php
must be patched in line 94:
old code in Joomla 3.4.1: <?php if ($canEdit) : ?>
New: <?php if ($canEdit || $canChange) : ?>

Steps to reproduce the issue

Create a user / group so that the user has the following calculated settings in the user com_user administration component.

Configure ACL & Options: Not Allowed
Access Administration Interface: Allowed
Create: Allowed
Delete: Not Allowed.
Edit: Not Allowed.
Edit: State Allowed

Log into the administrator backend with that user and access the user administration.

Expected result

The user should be able to block/unblock other users with the switches in the "enabled" column

Actual result

The user can see the block/unblock switches in the "Enabled" column but when clicking the status of the user is not changing.

The problem occurs because the tick-boxes in the userlist are not shown when the administrator has only EditState permission.

System information (as much as possible)

Any Joomla version from Joomla 2.5.28 until 3.4.1

Solution:
patch administrator/components/com_users/views/users/tmpl/default.php
in line 94:
old code in Joomla 3.4.1: <?php if ($canEdit) : ?>
New: <?php if ($canEdit || $canChange) : ?>

avatar geejay101 geejay101 - open - 7 Jun 2015
avatar zero-24 zero-24 - change - 7 Jun 2015
Category Administration
avatar zero-24 zero-24 - change - 7 Jun 2015
Status New Pending
Easy No Yes
avatar zero-24 zero-24 - change - 7 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 7 Jun 2015
Labels Added: ?
avatar watchfulli-dev
watchfulli-dev - comment - 8 Jun 2015

@test @geejay101 can you tell if this new user group should have as parent "Public" group or ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7134.

avatar watchfulli-dev watchfulli-dev - test_item - 8 Jun 2015 - Not tested
avatar geejay101
geejay101 - comment - 8 Jun 2015

In my configuration the parent is not public. It doesnt matter. The composite user permission is relevant.

avatar shre001
shre001 - comment - 9 Jun 2015

@test works


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7134.

avatar shre001 shre001 - test_item - 9 Jun 2015 - Tested successfully
avatar shre001 shre001 - test_item - 9 Jun 2015 - Tested successfully
avatar designbengel
designbengel - comment - 10 Jun 2015

@test Works fine :+1:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7134.

avatar designbengel designbengel - test_item - 10 Jun 2015 - Tested successfully
avatar zero-24 zero-24 - change - 10 Jun 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 10 Jun 2015

RTC. Thanks for the tests :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7134.

avatar zero-24 zero-24 - change - 10 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 10 Jun 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 11 Jun 2015
Milestone Added:
avatar Bakual
Bakual - comment - 12 Jun 2015

Merged into 3.5-dev with b121b4d
Thanks!

avatar Bakual Bakual - change - 12 Jun 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-06-12 13:38:54
Closed_By Bakual
avatar Bakual Bakual - close - 12 Jun 2015
avatar zero-24 zero-24 - close - 12 Jun 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment