? Success

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
4 Jun 2015

Adding feature to ArrayHelper::getColumn() that allows us to (optionally) use one of the columns as key for the returned array.
Currently this returns an indexed array always with auto indexes. This PR is made backward compatible with the previous implementation.

avatar izharaazmi izharaazmi - open - 4 Jun 2015
avatar izharaazmi
izharaazmi - comment - 4 Jun 2015

I could not find any test class for \Joomla\Utilities\ArrayHelper anywhere. Do let me know if it is anywhere around so that I can update it too.

avatar wilsonge
wilsonge - comment - 4 Jun 2015

Hi,
The libraries you have PR'd to here imported via composer from our framework. Can you please make this PR to the upstream Framework Utilities repository (https://github.com/joomla-framework/utilities) and when merged there it will be automatically included in the CMS when we next perform an update. You'll also find the unit tests in the framework repository :)

Thankyou!

avatar wilsonge wilsonge - close - 4 Jun 2015
avatar wilsonge wilsonge - change - 4 Jun 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-06-04 09:30:07
Closed_By wilsonge
avatar wilsonge wilsonge - close - 4 Jun 2015
avatar joomla-cms-bot joomla-cms-bot - close - 4 Jun 2015
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2015
Labels Added: ?
avatar izharaazmi izharaazmi - head_ref_deleted - 5 Sep 2015

Add a Comment

Login with GitHub to post a comment