? ? Success
Related to # 6941

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
15 May 2015

This PR moves the Filter options of the Newsfeeds to the [Search Tools] button.
Note: The ordering dropdown in [Search Tools] needs to be fixed before merging.
(See Issue #6941 regarding the inconsistency with Filter options).

Test instructions

In back-end > Components > Newsfeeds
See the filters on the left

screen shot 2015-05-15 at 08 07 33

Compare with the filters in Category Manager for Newsfeeds:
In back-end > Components > Newsfeeds > Categories

screen shot 2015-05-15 at 08 07 33

This PR changes moves the Filters

from the left to the middle column and will be visible when you click on the [Search Tools] button.

screen shot 2015-05-15 at 08 07 33

Notes:

I can use some help & suggestions regarding the following issues:

  • The ordering dropdown in [Search Tools] is currently not working
  • The /administrator/components/com_newsfeeds/views/newsfeeds/tmpl/default.php might have old obsolete code in it
  • The /administrator/components/com_newsfeeds/views/newsfeeds/view.html.php still has protected function getSortFields() which might be obsolete because the order options are now specified in /administrator/components/com_newsfeeds/models/forms/filter_newsfeeds.xml
avatar pe7er pe7er - open - 15 May 2015
avatar pe7er pe7er - change - 15 May 2015
The description was changed
avatar zero-24 zero-24 - change - 15 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 15 May 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 15 May 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 15 May 2015
Status New Pending
Rel_Number 0 6941
Relation Type Related to
avatar brianteeman
brianteeman - comment - 23 May 2015

After applying the patch the filters do move - great
BUT
After applying a filter they are hidden again - if you look at article manager they are still open


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6952.

avatar brianteeman brianteeman - test_item - 23 May 2015 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 23 May 2015

Also as Tag information is NOT visible in the list view it seems strange to me for their to be a filter


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6952.

avatar pe7er
pe7er - comment - 26 May 2015

Thanks for testing! I've to check the issue with the [Search Tools] closing after filtering.

I agree with removing the "Tag" filter as it's not displayed in any of the columns.

avatar m-b-o
m-b-o - comment - 30 May 2015

Works fine
BUT
the filters are hidden after applying


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6952.

avatar m-b-o m-b-o - test_item - 30 May 2015 - Tested successfully
avatar pe7er
pe7er - comment - 30 May 2015

Thanks for testing. I corrected the problem with the closing Search Tools for Category + Tags filter.
Now the [Search Tools] should remain opened when any of the filters has been selected.

avatar brianteeman
brianteeman - comment - 5 Jun 2015

Retested and all good now


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6952.

avatar brianteeman brianteeman - test_item - 5 Jun 2015 - Tested successfully
avatar brianteeman brianteeman - change - 5 Jun 2015
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 5 Jun 2015

Setting RTC now - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6952.

avatar brianteeman brianteeman - change - 5 Jun 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 5 Jun 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 6 Jun 2015
Milestone Added:
avatar shre001 shre001 - test_item - 10 Jun 2015 - Tested successfully
avatar mbabker mbabker - reference | c8b9875 - 11 Jul 15
avatar mbabker mbabker - close - 11 Jul 2015
avatar mbabker
mbabker - comment - 11 Jul 2015

Merged to 3.5-dev via c8b9875

avatar mbabker mbabker - change - 11 Jul 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-07-11 14:42:36
Closed_By mbabker
avatar mbabker mbabker - close - 11 Jul 2015
avatar roland-d roland-d - reference | f2ace72 - 6 Aug 15
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment