Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6937] - Fix colspan for com_content

? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
14 May 2015

This PR fixes the colspan for com_content Thanks goes to @pe7er for show here the way to fix such issue pe7er@d173053 :+1:

How to test

  • login into the backend
  • access com_content
  • switch to the featured view
  • make sure that the colspan is not to the end see

bevor_content_featured

  • apply the patch
  • make sure the line is not to the end of the screen like:

fixed_content_featured

  • similiar fix for com_content articles there this PR add the complete missing line there :smile:
  • success test.
avatar zero-24 zero-24 - open - 14 May 2015
avatar pe7er
pe7er - comment - 14 May 2015

Thanks Tobias!

@test

Patch fixes the colspan.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6937.

avatar pe7er pe7er - test_item - 14 May 2015 - Tested successfully
avatar roland-d
roland-d - comment - 14 May 2015

@test not OK. Before the patch there is no tfoot on the article list, after the patch there is a tfoot but it is 1 column short. It should be 11 instead of 10 in this case.

The tfoot on the featured view is OK.

avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 14 May 2015

Thanks @roland-d it is fixed now we need 11 if we have assoc enabled else we need 10. Thanks :smile:

avatar zero-24 zero-24 - change - 15 May 2015
Status New ⇒ Pending
Easy No ⇒ Yes
avatar zero-24 zero-24 - change - 15 May 2015
Category ⇒ Administration
avatar roland-d roland-d - test_item - 16 May 2015 - Tested successfully
avatar roland-d
roland-d - comment - 16 May 2015

@test all good now. The border runs to the end at the bottom.

avatar roland-d roland-d - change - 16 May 2015
Milestone Added:
avatar roland-d roland-d - change - 16 May 2015
Labels Added: ?
avatar roland-d roland-d - change - 16 May 2015
Labels Added: ?
avatar roland-d roland-d - change - 16 May 2015
Status Pending ⇒ Ready to Commit
avatar zero-24 zero-24 - close - 16 May 2015
avatar zero-24 zero-24 - change - 16 May 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-05-16 05:39:25
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 16 May 2015
avatar zero-24 zero-24 - close - 16 May 2015
avatar asika32764
asika32764 - comment - 16 May 2015

To my knowledge, maybe set colspan="20" can solve this problem?

avatar roland-d
roland-d - comment - 16 May 2015

@asika32764 The solution is fine as it is. The colspan is expanded where needed. Thanks.

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment