Feeling Lucky
?
[#6914] - Fixed primary key null not being respected
- Closed
- 10 May 2015
- Medium
- Build: staging
- # 6914
- Diff
- roland-d:publish-null
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Problem
If no primary key value is passed to the publish method it is now not being respected as it is turned into an array, the loaded state is not being used as should. This PR fixes this issue introduced in #6893
Test instructions
- Apply pull request #6900 first
-
Add the code below to the file administrator/component/com_cpanel/cpanel.php after line 10.
This will show the problem as we first unpublish the record and then publish it.require_once JPATH_ADMINISTRATOR.'/components/com_contact/tables/contact.php'; $row = JTable::getInstance('Contact', 'ContactTable'); $row->load(1); $row->publish(1, 0); $row->publish(); echo 'Published: ' . $row->published;
Load the administrator control panel and it shows Published: 0. This is wrong because we just published the record.
- Apply the patch
- Load the administrator control panel and it shows Published: 1. This is correct because we just published the record.
- Testing finished
zero-24
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
| Status | New | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-10 12:52:53 |
| Closed_By | ⇒ | roland-d |
| Milestone |
Added: |
||
| Labels |
Removed:
?
|
||
@test: Success.