[#6832] - ISSUE [#5709] - Removed duplicate message during login authorization
- Closed
- 7 May 2016
- Medium
- Build: staging
- # 6832
- Diff
- twhitloc:staging
- Foreign ID 5709
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Attempted to fix duplicate authentication warnings during login
-Go to sitename/administrator
-Enter valid username & enter invalid password
-Click on Login button twice, thrice as much as you can ;)
-Application will display multiple messages!
Solution:
-Button should trigger once.
Thank you for the help! I was trying to figure it out but the comment that showed up was a bit confusing to me :)
It's ok :) I remember how confusing it was to me when I started. If you fix these 3 issues I've commented travis should be happy!
Thank you, I will fix these issues and upload it later!
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
| Category | ⇒ | Administration Templates (admin) |
| Status | New | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
Please add blank line before each foreach or if or before any comment only before these.
Thank you infograf, I have added the spacing before the comment. Sorry for the delay.
I cannot reproduce this issue with current staging. Made lots of different tests and always got just 1 message. Is this error browser dependent?
But @brianteeman confirmed it #5709 (comment)
Just double checked
I dont see it in firefox at all BUT in chrome and safari I can replicate it for the blank password message but not for the username/password do not match message
Issue successful tested
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6832.
No, sorry but i still have the multiple messages after applying the patch...
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6832.
@designbengel: Which OS and Browser did you used for the test? I used Windows8, Firefox and Chrome:
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6832.
I tested on Safari 8.0.5 / Mac Os X Yosemite 10.10.3
Tested on Chrome, i still have the multiple messages too after applying the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6832.
Bug confirmed but the patch doesn't work.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6832.
But... is this a bug? When I click 3 times it means that I have 3 faulty attempts so 3 errors.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6832.
I also tested this and the PR doesn't solve the issue for me. Seeing the notice 3 times isn't an issue for me, if you click 3x you can get the message 3x. However what is an issue is that if you click 3x with a valid username/password you can get this message:
The most recent request was denied because it contained an invalid security token. Please refresh the page and try again.
As you said the button should be clickable once, this is better achieved using JavaScript like we do with other buttons, for example the article editing. Could you update the PR to give that a try?
| Status | Pending | ⇒ | Needs Review |
| Easy | Yes | ⇒ | No |
This issue should be solved in JavaScript. Thanks for raising this issue and for your contribution, but in the absence of a suitable PR for that, I'm closing this issue at this time.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6832.
joomla-cms-bot
- | Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-07 10:19:36 |
| Closed_By | ⇒ | zero-24 |
Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/6832
I do not understand these white space errors that are preventing the Travis build.