? Success

User tests: Successful: Unsuccessful:

avatar zero24
zero24
9 Apr 2015

What this PR do

After this PR the Update button after x Extension Update(s) are available redirect to the updates and show the list of updates as expected without clicking the Find Updates Button.

how to test

  • Install a outdated extension (e.g. 3.4.0.1 package of the german language pack)
  • access the backend
  • see the following screenshot extensions_updates
  • try e.g. the Update button
  • you get: befor_patch
  • where are the updates?
  • apply this patch
  • try the Update button again
  • we will show something like this: fixed_updates

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar zero24 zero24 - open - 9 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2015
Labels Added: ?
avatar phproberto
phproberto - comment - 9 Apr 2015

You can use tokens in urls.

avatar zero-24
zero-24 - comment - 9 Apr 2015
avatar phproberto
phproberto - comment - 9 Apr 2015

To get a token that you can attach to an URL:

$token = JSession::getFormToken() . '=' . 1
$url = JUri::base() . 'index.php?option=com_installer&view=update&task=update.find&' . $token;

Tokens sent by URL have to be validated with:

JSession::checkToken('get')
avatar zero-24
zero-24 - comment - 9 Apr 2015

Thanks @phproberto just implemented :smile:

avatar brianteeman
brianteeman - comment - 10 Apr 2015

Thanks for this +100

avatar phproberto
phproberto - comment - 10 Apr 2015

@zero24 I submitted a PR to your branch to add the token validation also for the update.ajax task zero24#1

avatar zero-24
zero-24 - comment - 10 Apr 2015

Thanks @phproberto works here!

avatar zero-24 zero-24 - change - 10 Apr 2015
Easy No Yes
avatar zero-24 zero-24 - change - 10 Apr 2015
Category UI/UX Updating
avatar infograf768
infograf768 - comment - 10 Apr 2015

:+1:

works great.
OK for you @nikosdion ?

avatar nikosdion
nikosdion - comment - 10 Apr 2015

I haven't tested it but I agree 100% with the concept. Looking at the code it's a trivial change (just a change of the task being called by the button – so simple!) so yep, it's OK with me :)

avatar infograf768
infograf768 - comment - 10 Apr 2015

@zero-24
I know we do not use quickicon there, but is there a way to automatically Find Languages when displaying Extension Manager: Install Languages ?

avatar zero-24
zero-24 - comment - 10 Apr 2015

I know we do not use quickicon there, but is there a way to automatically Find Languages when displaying Extension Manager: Install Languages ?

@infograf768 have a look into: #6729

avatar snarf007 snarf007 - test_item - 10 Apr 2015 - Tested successfully
avatar snarf007
snarf007 - comment - 10 Apr 2015

Applied the old German lanuage pack. Update button redirects to update page without the update. Applied patch. Now the update button directs to the update page with German language pack.
Test succesfull


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6727.
avatar dam-man
dam-man - comment - 10 Apr 2015

@test
Test completed and works like a charm.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6727.
avatar dam-man dam-man - test_item - 10 Apr 2015 - Tested successfully
avatar davdebcom davdebcom - test_item - 10 Apr 2015 - Tested successfully
avatar davdebcom
davdebcom - comment - 10 Apr 2015

@test
Works perfectly! No issues found.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6727.
avatar zero-24 zero-24 - change - 10 Apr 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 10 Apr 2015

Much thanks for testing and improving! Moving to RTC now.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6727.
avatar zero-24 zero-24 - change - 10 Apr 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 10 Apr 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-04-10 12:49:51
avatar wilsonge wilsonge - close - 10 Apr 2015
avatar wilsonge wilsonge - reference | - 10 Apr 15
avatar wilsonge wilsonge - merge - 10 Apr 2015
avatar wilsonge wilsonge - close - 10 Apr 2015
avatar zero-24 zero-24 - close - 10 Apr 2015
avatar zero-24 zero-24 - head_ref_deleted - 10 Apr 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment