[#6561] - Correctly allow PUT Curl requests
- Closed
- 17 Jun 2015
- Medium
- Build: staging
- # 6561
- Diff
- PhilETaylor:Issue6556-JHTTPNotSendingPutRequestsv2
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is a fork of the original PR #6550 and closes #6556
It seems that some resful apps require CURLOPT_POST (apparently) and so code was added in #6312 to ensure CURLOPT_POST was set
However there seems to be some curl bugs with CURLOPT_PUT that doesn't send the data right unless PUT is set in CURLOPT_CUSTOMREQUEST
This PR is a compromise between #6312 and the Joomla Framework (which has no large switch and just ALWAYS sets CURLOPT_CUSTOMREQUEST)
see comments in original Issue #6556
This implements the same method of setting the method that is used in the Joomla Framework - I.e not setting the individual curl options, but just sending it with CURLOPT_CUSTOMREQUEST
To test - apply patch and test any apps using JHttp and put - probably a fringe case as Joomla doesn't actually consume this method itself as far as I can tell.
Additionally the gist here has some test cases against a test endpoint https://gist.github.com/PhilETaylor/a4ee67f8f48d3674221d
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
Hi Phil,
I can confirm that this PR does fix the issue :-).
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6561.
brianteeman
- | Rel_Number | 0 | ⇒ | 6556 |
| Relation Type | ⇒ | Pull Request for |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-17 20:30:03 |
| Closed_By | ⇒ | wilsonge |
Merged - thanks Phil!
The reason I leave
case 'PUT':in, is to stop up going through all this again when someone notices its not there, leaving it in, as part of the default block (allowed in PHP) allows us to know in the future that it has been thought about and not just forgot it...