Feeling Lucky
?
[#6482] - Adding codeCoverageIgnore for defined check in JPagination package
- Closed
- 18 Mar 2015
- Medium
- Build: staging
- # 6482
- Diff
- Hackwar:patch-45
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
See title. This is for the codecoverage
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-18 01:29:15 |
mbabker
- comment
- 18 Mar 2015
I don't think flagging our defined or die checks is really going to make a difference on our code coverage except to pad it in a higher direction. I think I'm OK if we never reach 100% code coverage (and depending on how things are parsed, it won't happen, I sometimes get the close bracket of an if/elseif/else statement or method as uncovered).
This fails cause of codestyle and to be honest I'm not convinced by it. Even if I was we should do this across the entire libraries folder rather than in just this class