? ? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
17 Mar 2015

This a complimentary PR to #6467 from @nonumber

What is changed?

  1. All tags from <b> converted to <strong>
  2. The <h3> on the bootstrap modal is converted to <p class="lead><strong>

Results before applying this:

screen shot 2015-03-17 at 3 28 45

avatar dgt41 dgt41 - open - 17 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2015
Labels Added: ?
avatar nonumber
nonumber - comment - 17 Mar 2015

The <b class="caret"></b> should not be converted to strong, but to span. I have already done that in #6467

avatar dgt41
dgt41 - comment - 17 Mar 2015

Also this brings another point for discussion: the chosen script is throwing some <b> tags…
This can be either tapped by:
1. making a PR to their repo (even tho we use an outdated version)
2. patch it in jui folder
3. introduce select2 or bootstrap select

screen shot 2015-03-17 at 3 38 20

avatar dgt41
dgt41 - comment - 17 Mar 2015

Thanks @nonumber, will take it out from here

avatar brianteeman brianteeman - change - 17 Mar 2015
Category Accessibility
avatar nonumber
nonumber - comment - 17 Mar 2015

What is the reason for not using the <h3> in the modals?

avatar nonumber
nonumber - comment - 17 Mar 2015

For chosen: Best is to have them fix it on their side and then update to that version once it's fixed.
Best not to tamper with the 3rd party js files.

avatar nonumber
nonumber - comment - 17 Mar 2015
avatar dgt41
dgt41 - comment - 17 Mar 2015

H tags should cascade gracefully. Try users list view: there is an h1 for the title and if there is user note the modal title will be an h3 tag. But h3 should follow after an h2...

avatar dgt41
dgt41 - comment - 17 Mar 2015

@nonumber Peter the problem with chosen isn’t so simple. Joomla is using chosen v0.14 but chosen is now at v1.4.1. The problem is that with the release of version 1.0 they change all the selectors from chzn- to chosen- which obviously breaks backwards compatibility. Your PR is against the latest staging but here we still use something outdated, so even if that gets accepted we still can’t use that as it is incompatible with joomla’s b/c policy. Is kinda dead end situation with that code, that’s the reason I suggested to move on to select2 or bootstrap select...

avatar nonumber
nonumber - comment - 17 Mar 2015

Going by the explanation of the Chosen guys at harvesthq/chosen#2270 (comment) I think we'll just let this be for what it is.

avatar dgt41
dgt41 - comment - 12 May 2015

I don’t see much interest on this, so I am gonna close it.

avatar dgt41 dgt41 - change - 12 May 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-05-12 19:08:03
Closed_By dgt41
avatar dgt41 dgt41 - close - 12 May 2015
avatar joomla-cms-bot joomla-cms-bot - close - 12 May 2015
avatar dgt41 dgt41 - close - 12 May 2015
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2015
Labels Added: ?
avatar dgt41 dgt41 - head_ref_deleted - 26 May 2015

Add a Comment

Login with GitHub to post a comment