? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
17 Mar 2015

This patch is similar to #6445, but for the Language Manager.
To test, install Persian fa-IR or Arabic (ar-AA)
Go to
administrator/index.php?option=com_languages

before patch:

screen shot 2015-03-17 at 11 31 38

after patch

parenthesis_after

test that all works fine when switching to en-GB

avatar infograf768 infograf768 - open - 17 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 17 Mar 2015

Its not "perfect" as the text is still LTR it should read (en-GB) English
etc as you can see with the arabic

(Still better than current situaiton though)

On 17 March 2015 at 10:36, infograf768 notifications@github.com wrote:

This patch is similar to #6445
#6445, but for the Language
Manager.
To test, install Persian fa-IR or Arabic (ar-AA)
Go to
administrator/index.php?option=com_languages

before patch:

[image: screen shot 2015-03-17 at 11 31 38]
https://cloud.githubusercontent.com/assets/869724/6685386/b07689b2-cc99-11e4-849f-ebe915f1ed50.png

after patch

[image: parenthesis_after]

https://cloud.githubusercontent.com/assets/869724/6685391/b6fb2112-cc99-11e4-9340-03b081e8497f.png

You can view, comment on, or merge this pull request online at:

#6473
Commit Summary

  • RTL. Language Manager: Language Names wrong display of parenthesis

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#6473.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 17 Mar 2015

This is exactly what was obtained by #6445 in the administrator login module. And, for Arabic, there was no issue as it is read right to left.

avatar Kubik-Rubik
Kubik-Rubik - comment - 17 Mar 2015

This should be only added if a RTL language is loaded and not as default. I would prefer to have this addition in the model and not in the template file. Thanks!

avatar brianteeman
brianteeman - comment - 17 Mar 2015

I missed it in #6445 - the comment is valid there as well but really a
minor thing and not worth spending too much time on

I guess its always a questionable decision. Do you display LTR text in an
RTL manner when you are in RTL mode. You will probably find 50/50 answers
so just ignore it for now.

On 17 March 2015 at 10:46, Viktor Vogel notifications@github.com wrote:

This should be only added if a RTL language is loaded and not as default.
I would prefer to have this addition in the model and not in the template
file. Thanks!


Reply to this email directly or view it on GitHub
#6473 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 17 Mar 2015

@Kubik-Rubik
The result is the same if RTL language is loaded or not (that is why I suggested to test with en-GB).
Nevertheless, I changed to add the conditional and the correct code in the model instead of the template.

avatar Kubik-Rubik
Kubik-Rubik - comment - 17 Mar 2015

Thank you @infograf768!

Same solution as in #6449, I will merge this PR.

avatar Kubik-Rubik Kubik-Rubik - close - 17 Mar 2015
avatar Kubik-Rubik Kubik-Rubik - reference | - 17 Mar 15
avatar Kubik-Rubik Kubik-Rubik - merge - 17 Mar 2015
avatar Kubik-Rubik Kubik-Rubik - close - 17 Mar 2015
avatar Kubik-Rubik Kubik-Rubik - change - 17 Mar 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-03-17 11:21:08
avatar Kubik-Rubik Kubik-Rubik - change - 17 Mar 2015
Milestone Added:
avatar infograf768 infograf768 - head_ref_deleted - 18 Mar 2015

Add a Comment

Login with GitHub to post a comment