?
avatar iamkeng
iamkeng
17 Mar 2015

Steps to reproduce the issue

I would like to request more a filter, filter by assigned menu for Module Manager(module list page). When new user install Joomla and use Sample data and input the content by modify existing article. Somtime he/she want to know what modules are assigned by one of menu that he/she want to know. Thus I think this filter is necessary to use.

Expected result

The users can filter by 'Assigned Menu' that he/she want to filter.

Actual result

System information (as much as possible)

Additional comments

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar iamkeng iamkeng - open - 17 Mar 2015
avatar iamkeng iamkeng - change - 17 Mar 2015
Labels Removed: ?
avatar iamkeng
iamkeng - comment - 17 Mar 2015

I try to add this filter and this is the files that I done, you can download from http://demo.colorpack.net/module-manager-files.zip . Please try them.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6468.
avatar brianteeman brianteeman - change - 17 Mar 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 18 Mar 2015

Does not work here.

avatar iamkeng
iamkeng - comment - 18 Mar 2015

@infograf768 What's the results that you got?

avatar bertmert
bertmert - comment - 18 Mar 2015

@iamkeng

  • Install current staging Joomla plus test sample data
  • Add your code to files modules.php and view.html.php. (Be aware that there are some changes compared to your files that are Joomla 3.4.0).
  • Goto Module Manager
  • Open module "Top Menu (Atomic Template) ". 2 assigned menu items. One is "Typography Atomic" Close module.
  • In your filter field search for "Typography Atomic" and select.
  • Page reloads. Nothing changed.
  • Your filter returns to "nothing selected".
avatar iamkeng
iamkeng - comment - 20 Mar 2015

I include the modules that assigned to 'All' menus too.

avatar bertmert
bertmert - comment - 20 Mar 2015

Believe us. Nothing happens when you select a menu item with your filter.

There are several modules afterwards in the list with entry "Selected" in column "Pages" that are NOT assigned to menu item "Typography Atomic".

Create a Pull Request! Then it will be easier to test/discuss this issue.

avatar iamkeng
iamkeng - comment - 21 Mar 2015

What is a Pull Request? How can I do that?

avatar iamkeng
iamkeng - comment - 22 Mar 2015

@brianteeman I done the steps from your link and I commited to https://github.com/joomla/joomla-platform.git already but I cannot push my codes. Am I completed all steps?

avatar brianteeman brianteeman - change - 25 Mar 2015
Category Modules Feature Request Modules
avatar brianteeman
brianteeman - comment - 17 Jun 2015

@wilsonge @roland-d can you help out @iamkeng with making the Pull Request please


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6468.

avatar Bakual
Bakual - comment - 17 Jun 2015

I like that doc better for first time users: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

Aside that, you should not deal with https://github.com/joomla/joomla-platform. That's an outdated one. Work with the repo we are here (https://github.com/joomla/joomla-cms)

avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Apr 2016

Please test #9987

avatar brianteeman
brianteeman - comment - 28 Apr 2016

Closed as this has now been addressed with #9987


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6468.

avatar brianteeman brianteeman - change - 28 Apr 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-04-28 07:26:56
Closed_By brianteeman
avatar brianteeman brianteeman - close - 28 Apr 2016

Add a Comment

Login with GitHub to post a comment