[#6441] - Rework the existing controller legacy tests
- Closed
- 15 Mar 2015
- Medium
- Build: staging
- # 6441
- Diff
- wilsonge:controllertests
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Reworks the JControllerLegacy tests. This uses the @testdox tags that we are rolling out across Joomla and also breaks up the 11 parts of the setRedirect into separate tests. Finally I've added a test for injecting the controller name in the controller
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Unit Tests |
Just travis - I'm not touching core at all
A few comments:
- personally I would prefer "speaking" test names instead of names like test__construct()
- testCreateFileName() could be simplified by using a data provider
- setRedirect() could also be simplified by using a data provider, but using separate tests is fine for me too
All in all: good job! :)
| Status | Pending | ⇒ | Ready to Commit |
Thanks @wilsonge moving to RTC since Travis is happy with you here 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6441.
| Status | Ready to Commit | ⇒ | Pending |
moving back to pending as we have feedback by @SniperSister and @mbabker
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6441.
@SniperSister the setRedirect method is pretty hard to do via a data provider because half the tests also involve the setMessage method and how they override each other.
mbabker
- | Milestone |
Added: |
||
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-15 15:49:15 |
@wilsonge do we need to test here or only need travis pass the tests?