? Success
Referenced as Pull Request for: # 6465

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
13 Mar 2015

Bootstrap 2.3.2 default available file called media.less is missing in Isis template.
http://getbootstrap.com/2.3.2/components.html#media

example of use for this css output: when using an image in the description of an installed extension and you want to outline large text next to the image.

avatar hans2103 hans2103 - open - 13 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 14 Mar 2015
Category Templates (site)
avatar gorgonz
gorgonz - comment - 14 Mar 2015

Verified it in the templates.less of isis and saw the results in template.css - after compiling

avatar Bakual
Bakual - comment - 14 Mar 2015

@hans2103 Can you try running the file /build/generatecss.php from your CLI?
That would generate the template.css file for the Isis template and it could be tested better.

avatar Bloggerschmidt
Bloggerschmidt - comment - 14 Mar 2015

error on compiling template.less by /build/generatecss.php

expected color value: failed at ../media/jui/less/accordion.less";
C:\xampp\htdocs\pbf\administrator\templates\isis\less/template.less on line 48
expected color value: failed at 16.5%
C:\xampp\htdocs\pbf\administrator\templates\isis\less/template-rtl.less on line 100


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6417.
avatar Bloggerschmidt Bloggerschmidt - test_item - 14 Mar 2015 - Tested unsuccessfully
avatar jessicadunbar
jessicadunbar - comment - 15 Mar 2015

Compiled less in the isis templates.less - success after viewing source of template.css


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6417.
avatar jessicadunbar jessicadunbar - test_item - 15 Mar 2015 - Tested successfully
avatar gorgonz
gorgonz - comment - 15 Mar 2015
  1. try, more exactly now: before:
  2. media.less attribute ".media .media" not existing in template.css of isis
  3. compiling in the template and with help of generatecss.php did not change anything

after patch:

avatar gorgonz gorgonz - test_item - 16 Mar 2015 - Tested successfully
avatar hans2103
hans2103 - comment - 16 Mar 2015

@Bakual
just run "php buil/generatecss.php" from CLI
the result is not what I expexted. See comparison below.
staging...hans2103:staging

I was expecting to see new css lines in template.css from isis template.
I notice an import of media.less in template.css

avatar hans2103
hans2103 - comment - 16 Mar 2015

moment... I see what went wrong... typo main.less should be media.less. Oops

avatar hans2103
hans2103 - comment - 16 Mar 2015

This PR can be closed since I've made a new Pull Request #6465 containing changed less and compiled .css files.
Thank you @Bakual for explaining me how to compile from CLI in your comment above. Didn't knew that was possible to do.
#6465

avatar hans2103 hans2103 - change - 16 Mar 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-03-16 23:26:04
avatar hans2103 hans2103 - close - 16 Mar 2015

Add a Comment

Login with GitHub to post a comment