[#6273] - [fix] only define constants if they are not defined
- Closed
- 14 Mar 2015
- Medium
- Build: staging
- Easy Test
- # 6273
- Diff
- phproberto:jpath-component
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Description
We should never define a constant without checking if it's defined. When trying to use views to process the routes for their own view in my component I found that the component helper is called twice and then it's trying to define a constant that has been already defined.
Backward compatibility
There is no issue here. Just using the recommended way of doing things. Everything should work.
Test
Apply the patch and ensure that components are working properly.
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Easy | No | ⇒ | Yes |
| Category | ⇒ | Code style Libraries |
| Status | Pending | ⇒ | Ready to Commit |
Setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6273.
| Labels |
Added:
?
|
||
Putting the JPATH_COMPONENT_ADMINISTRATOR define onto a single line makes it too long for our code style rules (and I tried a couple of tricks), so for now I'll leave this as is so it's at least consistent and merge. Thanks!
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-14 14:59:35 |
| Labels |
Removed:
?
|
||
Code looks good to me. I have no problems with using components on front and backend
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6273.