? Success
Pull Request for # 6240

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
1 Mar 2015

Contact address is a textarea, so expected behaviour should be that linebreaks are allowed. Closes #6240

avatar PhilETaylor PhilETaylor - open - 1 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 1 Mar 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 1 Mar 2015
Title
Allow line breaks in Contact Address textarea to be rendered as <br/>'s
Allow line breaks in Contact Address textarea to be rendered as 's
Rel_Number 6240
Relation Type Pull Request for
avatar n9iels
n9iels - comment - 1 Mar 2015

please add some clear test instructions

avatar PhilETaylor
PhilETaylor - comment - 1 Mar 2015

To test - add a contact with an address that is multi line - so in the textbox for the contacts address put this:

Line1
Line2
Line3

and then check the contact address is rendered like that on the frontend.

Without this PR the output would become

Line1Line2Line3

Kindest regards
Phil.

avatar brianteeman
brianteeman - comment - 1 Mar 2015

Create a contact - add an address with more than one line
View the contact on the front end
The Address field will be on one line
Apply patch
The Address field will be on multiple lines

avatar brianteeman
brianteeman - comment - 1 Mar 2015

@PhilETaylor surely there is no need for the < br >

avatar PhilETaylor
PhilETaylor - comment - 1 Mar 2015

The ending trailing <br/> was already there, all the fields have it - I did not want to touch what might be there for a good reason... the reported issue was the output before that trailing br in the echo.

avatar n9iels
n9iels - comment - 1 Mar 2015

@test bug confirmed, the patch solves the bug. Thanks!

avatar PhilETaylor
PhilETaylor - comment - 1 Mar 2015

@n9iels Thank you for taking the time to test it.

avatar zero-24 zero-24 - change - 1 Mar 2015
Title
Allow line breaks in Contact Address textarea to be rendered as <br/>'s
Allow line breaks in Contact Address textarea to be rendered as 's
Easy No Yes
avatar brianteeman brianteeman - alter_testresult - 1 Mar 2015 - n9iels: Tested successfully
avatar zero-24 zero-24 - change - 1 Mar 2015
Category Components Front End
avatar waader waader - test_item - 2 Mar 2015 - Tested successfully
avatar waader
waader - comment - 2 Mar 2015

@test works! Thanks!

avatar PhilETaylor
PhilETaylor - comment - 2 Mar 2015

@waader Thanks for taking the time to test it.

avatar brianteeman
brianteeman - comment - 2 Mar 2015

Setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6243.
avatar brianteeman brianteeman - change - 2 Mar 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 2 Mar 2015
Labels Added: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 2 Mar 2015

Thank you @PhilETaylor!

avatar zero-24 zero-24 - close - 2 Mar 2015
avatar Kubik-Rubik Kubik-Rubik - change - 2 Mar 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-03-02 13:29:07
avatar Kubik-Rubik Kubik-Rubik - close - 2 Mar 2015
avatar Kubik-Rubik Kubik-Rubik - reference | - 2 Mar 15
avatar Kubik-Rubik Kubik-Rubik - merge - 2 Mar 2015
avatar Kubik-Rubik Kubik-Rubik - close - 2 Mar 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment