Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6032] - Cleaning up the checks in Modules renderer for performance

? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
9 Feb 2015

See #5996. This shuffles around the checks in the modules renderer to bail out as soon as possible for the module editing. The only functional change is, that module editing with this requires that the user is logged in regardless of the permissions set. The situation that an unauthenticated user is allowed to edit modules in the frontend, is VERY uncommon.

How to test

  • Install current staging
  • See times of beforeRenderModule module in debugging
  • Apply patch
  • See times have cut down to about a tenth of the original value

Make sure that you are not logged in when doing this. There should be no change in performance if the user is logged in.

avatar Hackwar Hackwar - open - 9 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 9 Feb 2015

@test MASSIVE improvement thanks

before

screen shot 2015-02-09 at 16 32 45

after

screen shot 2015-02-09 at 16 32 55

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6032.
avatar brianteeman brianteeman - test_item - 9 Feb 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 9 Feb 2015

Hit post too early. As you can see there are no duplicate queries now. So the queries take 3 second less

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6032.
avatar dgt41
dgt41 - comment - 9 Feb 2015

@test ok. I also agree to set front end editing default value to disabled

Multilingual (en, gr) default install data
Before:
screen shot 2015-02-10 at 12 48 56

After:
screen shot 2015-02-10 at 12 49 38

avatar zero-24 zero-24 - change - 11 Feb 2015
Status Pending ⇒ Ready to Commit
avatar zero-24 zero-24 - change - 11 Feb 2015
Easy No ⇒ Yes
avatar infograf768
infograf768 - comment - 11 Feb 2015

@test
Done on my multilingual test site, home page default site language:
Guest
Before 6032:

before6032

After 6032

after6032

After but LOGGED as REGISTERED USER:

6032registered

After but LOGGED as REGISTERED USER after switching to French Home page:

registeredswitch

After logging out on same French Home page:

logingoutfrench

Switching to Italian Home page (still as guest)

switchitalian

Switching to German Home page (still as guest)

switchinggerman

Switching to French Home page (still as guest)

switchfrench

NOTE: French has more menu items (+11) and one more module (Archived)

avatar zero-24 zero-24 - change - 12 Feb 2015
Category ⇒ Libraries Modules
avatar zero-24 zero-24 - alter_testresult - 16 Feb 2015 - dgt41: Tested successfully
avatar zero-24 zero-24 - alter_testresult - 16 Feb 2015 - infograf768: Tested successfully
avatar zero-24
zero-24 - comment - 16 Feb 2015

Thanks @Hackwar i can't do more than move to RTC! Thanks for coding and testing here!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6032.
avatar wilsonge wilsonge - close - 17 Feb 2015
avatar wilsonge wilsonge - reference | - 17 Feb 15
avatar wilsonge wilsonge - merge - 17 Feb 2015
avatar wilsonge wilsonge - close - 17 Feb 2015
avatar wilsonge wilsonge - change - 17 Feb 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-02-17 11:31:45
avatar wilsonge
wilsonge - comment - 17 Feb 2015

Merged. Thankyou very much Hannes!

avatar wilsonge wilsonge - change - 17 Feb 2015
Milestone Added:
avatar Hackwar Hackwar - head_ref_deleted - 6 Jan 2016

Add a Comment

Login with GitHub to post a comment