[#5849] - Use the new wrapper classes in the filesystem package
- Closed
- 28 Jan 2015
- Medium
- Build: staging
- Easy Test
- # 5849
- Diff
- mbabker:UseFilesystemWrapper
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Redo of #4827
From our testing sprint in October, we've taken some initial steps to modernize some of our architecture and focus on replacing static methods as able. To do so without backward compatibility breaks, we've introduced several wrapper classes which are object based and enable developers to utilize these to work with what will be the object based API in a later major release.
This PR demonstrates how the wrappers can be used internally by using the newly created wrappers for the Filesystem package within its classes. In conjunction with #4717 this demonstrates how we can begin modernizing the code in phased steps without introducing larger B/C breaks between major releases by providing a compatibility layer in our current releases.
Testing Instructions
- Apply the patch
- Perform actions in the user interface that interact with the filesystem (the media manager and extension manager are great places to test from)
- Ensure filesystem management still works
jissues-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
| Easy | No | ⇒ | Yes |
test
works good here
tried upload/create/delete in media manager, and install/uninstall extensions
Working fine in media manager. Tried to Add, remove file and create folder. Tried to install and upgrade component. All working fine for me.
Testing Environment:
PHP Built On Linux gunjan 3.13.0-43-generic #72-Ubuntu SMP Mon Dec 8 19:35:06 UTC 2014 x86_64
Database Version 5.5.40-0ubuntu0.14.04.1
Database Collation utf8_general_ci
PHP Version 5.5.9-1ubuntu4.5
Web Server Apache/2.4.7 (Ubuntu)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5849.
Has two tests - setting RTC - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5849.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-28 18:41:04 |
| Labels |
Removed:
?
|
||
Thank you for the new PR, I will look into it in more detail soon!