[#5766] - Added a 'No matches found' div for Module Manager::Login::Menu Assignment.
- Closed
- 19 Jan 2015
- Medium
- Build: staging
- Easy Test
- # 5766
- Diff
- prasoon2211:issue5736
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
A div added to the end of the list that is displayed when the result is empty.
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Language & Strings UI/UX |
| Rel_Number | ⇒ | 5736 | |
| Relation Type | ⇒ | Pull Request for | |
| Easy | No | ⇒ | Yes |
@prasoon2211 any how (don't ask me why) I'm unable to test this here successful. Other words the message will not show to me.
I tryed both com_patchtester and a clean install of your branche but both dont work.
@test tried and no difference
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5766.
@test OK if debug is on
Which means that the file media/jui/js/treeselectmenu.jquery.*min*.js needs to be updated as well
@prasoon2211 can you minify the js?
Please, do not create a new language string when we have a global string:
JGLOBAL_NO_MATCHING_RESULTS="No Matching Results"
also, should not we use the same formatting as elsewhere in admin i.e.
<div id="noresultsfound" style="display:none;" class="alert alert-no-items">
<?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
</div>
which gives:
@infograf768 Okay. It looks like everything is done. Should I squash the commits?
@test works for me now
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5766.
| Status | Pending | ⇒ | Ready to Commit |
Thanks @test successful moving to RTC.
Should I squash the commits?
Yes Thanks @prasoon2211
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5766.
roland-d
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-19 21:44:12 |
Can someone please look at this? This fix is pretty minor. Let me know if I should change anything.