Paging @brianteeman as he knows more about how I need to get language strings translated etc..

Phil check the NEW plugin in staging called captcha NoCaptcha (iirc) and
the discussion on that
On 2 Jan 2015 23:28, "Phil Taylor" notifications@github.com wrote:

Paging @brianteeman https://github.com/brianteeman as he knows more
about how I need to get language strings translated etc..

—
Reply to this email directly or view it on GitHub
#5593 (comment).

Looks like noCaptcha has this change already, but if the Recaptcha plugin is going to ship as well as the nocaptcha plugin then this is still needed

Ok I will double check in the morning. Not at my pc
On 2 Jan 2015 23:34, "Phil Taylor" notifications@github.com wrote:

Looks like noCaptcha also needs this language change then...

—
Reply to this email directly or view it on GitHub
#5593 (comment).

Let me post my updated comment so you get as an email :-)

Looks like noCaptcha has this change already, but if the Recaptcha plugin is going to ship as well as the nocaptcha plugin then this is still needed

Simple fix - setting RTC

This has to be squashed before merging.

er - how do I do that?

On 3 Jan 2015, at 08:18, infograf768 notifications@github.com wrote:

This has to be squashed before merging.

—
Reply to this email directly or view it on GitHub.

er - how do I do that?

The commiter bevor comitting

@PhilETaylor can you fix the names also here:

https://github.com/PhilETaylor/joomla-cms/blob/ClearConfusionOverReCaptchaKeyNames/administrator/language/en-GB/en-GB.plg_captcha_recaptcha.ini#L24-25
and here
https://github.com/PhilETaylor/joomla-cms/blob/ClearConfusionOverReCaptchaKeyNames/administrator/language/en-GB/en-GB.plg_captcha_recaptcha.ini#L29-30

@PhilETaylor I submitted a PR to your branch to fix the missing changes that @zero24 found. Just accept the PR into your branch and this can be committed. Thanks

Can this be committed please as I would like to submit a PR to resolve #5595 but it will conflict

@brianteeman

can you include into your new patch this two strings that still calls private and public Key?

https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.plg_captcha_recaptcha.ini#L11
and
https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.plg_captcha_recaptcha.ini#L13

Thanks.

@zero24 this has been committed by Michael. Did I miss something

@zero-24 please see #5656