Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5501] - Routing: Legacy Router Rule for com_content

? ? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
23 Dec 2014

This implements the current routers behavior of com_content as a legacyrouter. This is meant for those that want to keep the old behavior at all costs. Later, parameters will be introduced to switch between the legacy behavior and new features.

This router is copied verbatim from the current router to make sure that the same behavior is kept. No changes should be done to it until Joomla 4.0, when this is supposed to be deleted. The component routers right now are so fragile, that a slow transition will be next to impossible. To prevent any breaks in backwards compatibility, this legacy router is introduced, so that people having problems with the new router can switch back.

How to test

  1. Check your site before applying the patch and see the URLs of com_content.
  2. Apply the patch.
  3. See the URLs of com_content to stay the same.

This was made possible through the generous donation of the people mentioned in the following link via an Indiegogo campaign: http://joomlager.de/crowdfunding/5-contributors

avatar Hackwar Hackwar - open - 23 Dec 2014
avatar jissues-bot jissues-bot - change - 23 Dec 2014
Labels Added: ?
avatar zero-24
zero-24 - comment - 23 Dec 2014

@Hackwar Travis fails on:

There was 1 error:
1) JRouterSiteTest::testGetComponentRouter
Invalid argument supplied for foreach()
/home/travis/build/joomla/joomla-cms/libraries/cms/component/router/rules/menu.php:147
/home/travis/build/joomla/joomla-cms/libraries/cms/component/router/rules/menu.php:44
/home/travis/build/joomla/joomla-cms/components/com_content/router.php:30
/home/travis/build/joomla/joomla-cms/libraries/cms/router/site.php:690
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/router/JRouterSiteTest.php:791

also two CS issues: (see: Hackwar#14)

FILE: ...build/joomla/joomla-cms/components/com_content/helpers/legacyrouter.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
  48 | ERROR | Whitespace found at end of line
 479 | ERROR | Please end your files with an empty line.
--------------------------------------------------------------------------------

https://travis-ci.org/joomla/joomla-cms/jobs/44966357

avatar zero-24 zero-24 - change - 23 Dec 2014
Category ⇒ Router / SEF
avatar Hackwar
Hackwar - comment - 23 Dec 2014

thx @zero-24

avatar paternax
paternax - comment - 14 Mar 2015

Klicking on a tag of a tagged article gives following notices:
Notice: Trying to get property of non-object in C:\xampp\htdocs\joomla-cms\libraries\cms\component\router\rules\menu.php on line 58

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5501.
avatar paternax paternax - test_item - 14 Mar 2015 - Tested unsuccessfully
avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2015
Labels Added: ?
avatar Hackwar
Hackwar - comment - 23 May 2015

This has been updated to work with the latest implementation of JComponentRouterView. Please test.

avatar Hackwar Hackwar - change - 24 May 2015
The description was changed
avatar Hackwar
Hackwar - comment - 2 Aug 2015

I've combined the changes from this and all other routing related PRs into a new PR: #7615 Please review and comment in the new PR. I'm closing this one, so that we can focuse on the new PR.

avatar Hackwar Hackwar - change - 2 Aug 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-08-02 16:21:40
Closed_By ⇒ Hackwar
avatar Hackwar Hackwar - close - 2 Aug 2015
avatar Hackwar Hackwar - head_ref_deleted - 6 Jan 2016

Add a Comment

Login with GitHub to post a comment