? Success

User tests: Successful: Unsuccessful:

avatar smz
smz
19 Dec 2014

For issue description please see #4937

This first commit is just a kludge (or is it a nice hack?) equating the value of the option for "All" categories (-1) to the really big int 2147483647 (the biggest representable in 32bit PHP compiles)

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar smz smz - open - 19 Dec 2014
avatar jissues-bot jissues-bot - change - 19 Dec 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 19 Dec 2014

This works fine here.
remains to do the js for the other core components (weblinks should be done in its own repo)

avatar smz
smz - comment - 19 Dec 2014

Ah, yes, you're right... Will look for which other components we have similar views and fix those too...

What about the string talking about "Subcategoires"?

avatar smz smz - reference | 93a0934 - 19 Dec 14
avatar smz
smz - comment - 19 Dec 2014

PR for weblinks is joomla-extensions/weblinks#21

avatar infograf768
infograf768 - comment - 19 Dec 2014

Thanks. Let's leave the string alone imho.

One more tester.

avatar infograf768 infograf768 - test_item - 20 Dec 2014 - Tested successfully
avatar richard67
richard67 - comment - 20 Dec 2014

@smz @infograf768 I just have tested with success for com_content and com_contact, but not for com_newsfeed. Can this be regarded as successful test of this PR?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5469.

avatar richard67
richard67 - comment - 20 Dec 2014

@smz @infograf768 P.S.: I mean I just did not test for com_newsfeeds, so I don't know if for these it is ok, too, or not. But a code review should show that the changes for these are the same as the (succesfully tested) changes for com_content and com_contact, so maybe my test is sufficient.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5469.

avatar richard67
richard67 - comment - 20 Dec 2014

@test Tested now with success for com_content, com_contact and com_newsfeeds.
@smz It would be perfect if there was some tool tipp telling what the new +/- button is good for, if this is not Joomla! standard somehow so it is clear or not mentioned in docmuments.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5469.

avatar richard67 richard67 - test_item - 20 Dec 2014 - Tested successfully
avatar smz
smz - comment - 20 Dec 2014

@richard67 Richard, it is good that you tested this patch with com_contact and com_newsfeed too as... I actually didn't!! :smile:

The tooltip Idea IMHO is a good one, but probably I will write it down in the "TODO" list and leave it for the next fix release (so much to do now...)

<rant>I think com_contact and com_newsfeeds should burn in the JED hell together with com_weblinks. I think this is planned for 3.5 (but I may be wrong...). As far as regards com_newsfeeds I'm really tempted to plant a major bug in it and see what happens! Maybe a totally broken front-end functionality and, in the back-end, a jester popping out from the screen saying "Gotcha! This is a trick... press the button here below to restore full functionality!" Of course the button should also ping a joomla.org server so we can tally how many in the fields are actually using this... Am I too mean?</rant>

avatar richard67
richard67 - comment - 20 Dec 2014

@smz Just a question: What do these "rant" tags mean? ;-)

avatar smz
smz - comment - 20 Dec 2014

@richard67 a rant... is vehement protest! :stuck_out_tongue_winking_eye:

avatar richard67
richard67 - comment - 20 Dec 2014

@smz Seems the issue tracker does not support this tag yet or is is meanwhile HTML5-Standard? :stuck_out_tongue_winking_eye:

avatar smz
smz - comment - 20 Dec 2014

ehehehheheheh!! HTML6!!!

avatar infograf768 infograf768 - change - 21 Dec 2014
Milestone Added:
avatar infograf768 infograf768 - close - 21 Dec 2014
avatar infograf768 infograf768 - close - 21 Dec 2014
avatar infograf768 infograf768 - change - 21 Dec 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-12-21 08:38:49
avatar infograf768
infograf768 - comment - 21 Dec 2014

Thanks. Merged.

avatar smz
smz - comment - 21 Dec 2014

@infograf768 There is something strange with this merge: I see it as "Closed" (not "Merged") and I also have this message:

Closed with unmerged commits
This pull request is closed, but the smz:CategoriesLevelAll branch has unmerged commits.
avatar richard67
richard67 - comment - 21 Dec 2014

@smz I see the same for my PR #5331 . Checking with staging has shown that merge was ok, and for your PR here it seemded, so, too (brief check only with bcompare). Unmerged commits could be in my case some in the middle of work for code style. So I am only confused about status = closed and not merged, but not about the unmerged commits.

avatar smz
smz - comment - 21 Dec 2014

... I'm pretty sure I didn't make any mod/sync to this branch... curious....

avatar richard67
richard67 - comment - 21 Dec 2014

well, my mistake, have corrected my comment above meanwhile in github but issue tracker might show still old version. was not synch commits i had, was code style stuff for travis. maybe these intermediate steps have not been counted as comitted somehow and so make this strange unmerged commits message?

avatar Bakual
Bakual - comment - 21 Dec 2014

That message means the PR got merged, but not directly as a merge-commit. Instead we pulled the commits and squashed them, and then commited.
You can see the resulting commit here: cf88e6b

avatar smz smz - head_ref_deleted - 21 Dec 2014
avatar Harmageddon Harmageddon - reference | 804a631 - 16 Sep 15

Add a Comment

Login with GitHub to post a comment