?
avatar zero-24
zero-24
7 Dec 2014

Steps to reproduce the issue

Expected result

Upgrade runs without erros

Actual result

Notice: Undefined property: InstallerController::$input in JROOT\administrator\components\com_installer\controller.php on line 37

Fatal error: Call to a member function get() on a non-object in JROOT\administrator\components\com_installer\controller.php on line 37

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar zero-24 zero-24 - open - 7 Dec 2014
avatar zero-24 zero-24 - change - 7 Dec 2014
The description was changed
avatar zero-24
zero-24 - comment - 7 Dec 2014

IIRC this is a simple fix like:

if (!$this->input)
{
$this->app = XXX
}

But i don't know what is XXX here :smile:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5344.

avatar mbabker
mbabker - comment - 7 Dec 2014

The only thing I can think here is that when InstallerController::display is called, the 2.5 version of JControllerLegacy is still getting called. Could you check your filesystem and check if you have a class at libraries/cms/controller/legacy.php?

It REALLY shouldn't be needed if the right class is getting loaded, but setting $this->input = JFactory::getApplication()->input would fix it.

avatar infograf768
infograf768 - comment - 8 Dec 2014

I get the same issue. But it goes further as, after this error, trying to load any manager displays the same error.
For example:
( ! ) Notice: Undefined property: BannersController::$input in /Applications/MAMP/htdocs/Joomla_2.5.28.rc/administrator/components/com_banners/controller.php on line 34

We do have in legacy.php

defined('JPATH_PLATFORM') or die;

jimport('joomla.application.component.controller');

/**
 * Alias to JController for forward compatability.
 *
 * @package     Joomla.Libraries
 * @subpackage  Controller
 * @since       2.5.5
 */
class JControllerLegacy extends JController
{
}
avatar infograf768
infograf768 - comment - 8 Dec 2014

So it looks like the legacy/controller/legacy.php file is not yet loaded, but instead the cms one (code above). Script.php is not yet ran and db updates neither.

avatar brianteeman brianteeman - change - 8 Dec 2014
Category Updating
avatar wilsonge
wilsonge - comment - 8 Dec 2014

Did doing the upgrade this way (through extension manager) going from 2.5.28 to 3.3.6 work?

avatar mbabker
mbabker - comment - 8 Dec 2014

Because of the autoloader rules, the lookup order is libraries/cms, libraries/joomla, then libraries/legacy. If the 2.5 code still exists on a 3.x request, then the 2.5 version of JControllerLegacy will be loaded in before the correct 3.x version.

avatar mbabker
mbabker - comment - 8 Dec 2014

@zero-24 If you have time, I have a test package (link shared in JBS Skype) which fixes the SQL errors from the EOS plugin. IIRC, the SQL updates are processed before our install script's postflight (which handles the file deletions), so those SQL issues could lead to this error condition. With that fixed, this shouldn't be an issue.

avatar infograf768
infograf768 - comment - 9 Dec 2014

Tested installing first a clean 2.5.28-dev (github version with the EOS id chnaged to 900) without any sample data

I have a database error:

Warning: Database is not up to date!
    Table 'jos_user_profiles' does not have column 'profile_value' with type 'TEXT'. (From file 2.5.28.sql.)

Clicking on the fix button solves it.
( I guess we should fix this as joomla.sql has varchar(255) instead of TEXT

CREATE TABLE IF NOT EXISTS `#__user_profiles` (
  `user_id` int(11) NOT NULL,
  `profile_key` varchar(100) NOT NULL,
  `profile_value` varchar(255) NOT NULL,
  `ordering` int(11) NOT NULL default '0',
  UNIQUE KEY `idx_user_id_profile_key` (`user_id`,`profile_key`)
)  DEFAULT CHARSET=utf8 COMMENT='Simple user profile storage table';

)

Then using Extension Manager=>install from a downloaded http://developer.joomla.org/cms-packages/Joomla_3.4.0-dev-Development-Update_Package.zip

I do not have any more the $input issue.
I have though dozens of errors concerning "manifest cache" that could not be updated displaying in the manager.
screen shot 2014-12-09 at 08 22 47

No database error.

avatar infograf768
infograf768 - comment - 9 Dec 2014

For the database fix, please see
#5362

avatar Kubik-Rubik
Kubik-Rubik - comment - 9 Dec 2014

@mbabker RC2 fixes the $inpute bug but I still get the manifest cache error (also with #5362).

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5344.

avatar mbabker
mbabker - comment - 9 Dec 2014

Didn't think the manifest cache issue would get fixed with the $input thing sorted out. Still have no idea on that truthfully.

avatar Kubik-Rubik
Kubik-Rubik - comment - 10 Dec 2014

The main problem ($input) was fixed with the RC2 version, so I set the status to "Normal".

Though, we can not close this issue yet because the problem with the manifest caching still is not fixed. @mbabker and I tried to identify the source of the problem and isolated the problem to a database connection issue. Working on it!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5344.

avatar Kubik-Rubik Kubik-Rubik - change - 10 Dec 2014
Priority Critical Medium
avatar infograf768
infograf768 - comment - 10 Dec 2014

:+1:

avatar zero-24
zero-24 - comment - 20 Dec 2014

Though, we can not close this issue yet because the problem with the manifest caching still is not fixed. @mbabker and I tried to identify the source of the problem and isolated the problem to a database connection issue. Working on it!

@Kubik-Rubik @mbabker

I'm not sure but i have found this here (but not tested atm):
http://stackoverflow.com/questions/27173442/how-to-solve-error-on-updating-manifest-cache-type-element-folder-client-o
http://www.inmotionhosting.com/support/edu/joomla-25/refresh-manifest-cache-failed

I hopt it helps to find and fix the issue.

avatar infograf768
infograf768 - comment - 23 Dec 2014

Looks like the proposed solutions did not work for that user.

avatar infograf768
infograf768 - comment - 29 Dec 2014

As $input issue was solved, changing title to fit remaining issue with manifest cache

avatar zero-24
zero-24 - comment - 31 Dec 2014

@Kubik-Rubik @mbabker any progress on the manifest cache issue? or should i open a new Issue for that as this was created for the allready fixed $input issue :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5344.
avatar mbabker
mbabker - comment - 31 Dec 2014

It's fine. The query that's built is this:

SELECT *
FROM `#__extensions`
WHERE type='component' AND element='com_mailto' AND folder='' AND client_id=0 OR type='component' AND element='com_wrapper' AND folder='' AND client_id=0 OR type='component' AND element='com_admin' AND folder='' AND client_id=1 OR type='component' AND element='com_ajax' AND folder='' AND client_id=1 OR type='component' AND element='com_banners' AND folder='' AND client_id=1 OR type='component' AND element='com_cache' AND folder='' AND client_id=1 OR type='component' AND element='com_categories' AND folder='' AND client_id=1 OR type='component' AND element='com_checkin' AND folder='' AND client_id=1 OR type='component' AND element='com_contact' AND folder='' AND client_id=1 OR type='component' AND element='com_cpanel' AND folder='' AND client_id=1 OR type='component' AND element='com_installer' AND folder='' AND client_id=1 OR type='component' AND element='com_languages' AND folder='' AND client_id=1 OR type='component' AND element='com_login' AND folder='' AND client_id=1 OR type='component' AND element='com_media' AND folder='' AND client_id=1 OR type='component' AND element='com_menus' AND folder='' AND client_id=1 OR type='component' AND element='com_messages' AND folder='' AND client_id=1 OR type='component' AND element='com_modules' AND folder='' AND client_id=1 OR type='component' AND element='com_newsfeeds' AND folder='' AND client_id=1 OR type='component' AND element='com_plugins' AND folder='' AND client_id=1 OR type='component' AND element='com_search' AND folder='' AND client_id=1 OR type='component' AND element='com_templates' AND folder='' AND client_id=1 OR type='component' AND element='com_content' AND folder='' AND client_id=1 OR type='component' AND element='com_config' AND folder='' AND client_id=1 OR type='component' AND element='com_redirect' AND folder='' AND client_id=1 OR type='component' AND element='com_users' AND folder='' AND client_id=1 OR type='component' AND element='com_tags' AND folder='' AND client_id=1 OR type='component' AND element='com_contenthistory' AND folder='' AND client_id=1 OR type='component' AND element='com_postinstall' AND folder='' AND client_id=1 OR type='library' AND element='phpmailer' AND folder='' AND client_id=0 OR type='library' AND element='simplepie' AND folder='' AND client_id=0 OR type='library' AND element='phputf8' AND folder='' AND client_id=0 OR type='library' AND element='joomla' AND folder='' AND client_id=0 OR type='library' AND element='idna_convert' AND folder='' AND client_id=0 OR type='library' AND element='fof' AND folder='' AND client_id=0 OR type='library' AND element='phpass' AND folder='' AND client_id=0 OR type='module' AND element='mod_articles_archive' AND folder='' AND client_id=0 OR type='module' AND element='mod_articles_latest' AND folder='' AND client_id=0 OR type='module' AND element='mod_articles_popular' AND folder='' AND client_id=0 OR type='module' AND element='mod_banners' AND folder='' AND client_id=0 OR type='module' AND element='mod_breadcrumbs' AND folder='' AND client_id=0 OR type='module' AND element='mod_custom' AND folder='' AND client_id=0 OR type='module' AND element='mod_feed' AND folder='' AND client_id=0 OR type='module' AND element='mod_footer' AND folder='' AND client_id=0 OR type='module' AND element='mod_login' AND folder='' AND client_id=0 OR type='module' AND element='mod_menu' AND folder='' AND client_id=0 OR type='module' AND element='mod_articles_news' AND folder='' AND client_id=0 OR type='module' AND element='mod_random_image' AND folder='' AND client_id=0 OR type='module' AND element='mod_related_items' AND folder='' AND client_id=0 OR type='module' AND element='mod_search' AND folder='' AND client_id=0 OR type='module' AND element='mod_stats' AND folder='' AND client_id=0 OR type='module' AND element='mod_syndicate' AND folder='' AND client_id=0 OR type='module' AND element='mod_users_latest' AND folder='' AND client_id=0 OR type='module' AND element='mod_whosonline' AND folder='' AND client_id=0 OR type='module' AND element='mod_wrapper' AND folder='' AND client_id=0 OR type='module' AND element='mod_articles_category' AND folder='' AND client_id=0 OR type='module' AND element='mod_articles_categories' AND folder='' AND client_id=0 OR type='module' AND element='mod_languages' AND folder='' AND client_id=0 OR type='module' AND element='mod_tags_popular' AND folder='' AND client_id=0 OR type='module' AND element='mod_tags_similar' AND folder='' AND client_id=0 OR type='module' AND element='mod_custom' AND folder='' AND client_id=1 OR type='module' AND element='mod_feed' AND folder='' AND client_id=1 OR type='module' AND element='mod_latest' AND folder='' AND client_id=1 OR type='module' AND element='mod_logged' AND folder='' AND client_id=1 OR type='module' AND element='mod_login' AND folder='' AND client_id=1 OR type='module' AND element='mod_menu' AND folder='' AND client_id=1 OR type='module' AND element='mod_popular' AND folder='' AND client_id=1 OR type='module' AND element='mod_quickicon' AND folder='' AND client_id=1 OR type='module' AND element='mod_stats_admin' AND folder='' AND client_id=1 OR type='module' AND element='mod_status' AND folder='' AND client_id=1 OR type='module' AND element='mod_submenu' AND folder='' AND client_id=1 OR type='module' AND element='mod_title' AND folder='' AND client_id=1 OR type='module' AND element='mod_toolbar' AND folder='' AND client_id=1 OR type='module' AND element='mod_multilangstatus' AND folder='' AND client_id=1 OR type='plugin' AND element='gmail' AND folder='authentication' AND client_id=0 OR type='plugin' AND element='joomla' AND folder='authentication' AND client_id=0 OR type='plugin' AND element='ldap' AND folder='authentication' AND client_id=0 OR type='plugin' AND element='contact' AND folder='content' AND client_id=0 OR type='plugin' AND element='emailcloak' AND folder='content' AND client_id=0 OR type='plugin' AND element='loadmodule' AND folder='content' AND client_id=0 OR type='plugin' AND element='pagebreak' AND folder='content' AND client_id=0 OR type='plugin' AND element='pagenavigation' AND folder='content' AND client_id=0 OR type='plugin' AND element='vote' AND folder='content' AND client_id=0 OR type='plugin' AND element='codemirror' AND folder='editors' AND client_id=0 OR type='plugin' AND element='none' AND folder='editors' AND client_id=0 OR type='plugin' AND element='tinymce' AND folder='editors' AND client_id=0 OR type='plugin' AND element='article' AND folder='editors-xtd' AND client_id=0 OR type='plugin' AND element='image' AND folder='editors-xtd' AND client_id=0 OR type='plugin' AND element='pagebreak' AND folder='editors-xtd' AND client_id=0 OR type='plugin' AND element='readmore' AND folder='editors-xtd' AND client_id=0 OR type='plugin' AND element='categories' AND folder='search' AND client_id=0 OR type='plugin' AND element='contacts' AND folder='search' AND client_id=0 OR type='plugin' AND element='content' AND folder='search' AND client_id=0 OR type='plugin' AND element='newsfeeds' AND folder='search' AND client_id=0 OR type='plugin' AND element='tags' AND folder='search' AND client_id=0 OR type='plugin' AND element='languagefilter' AND folder='system' AND client_id=0 OR type='plugin' AND element='p3p' AND folder='system' AND client_id=0 OR type='plugin' AND element='cache' AND folder='system' AND client_id=0 OR type='plugin' AND element='debug' AND folder='system' AND client_id=0 OR type='plugin' AND element='log' AND folder='system' AND client_id=0 OR type='plugin' AND element='redirect' AND folder='system' AND client_id=0 OR type='plugin' AND element='remember' AND folder='system' AND client_id=0 OR type='plugin' AND element='sef' AND folder='system' AND client_id=0 OR type='plugin' AND element='logout' AND folder='system' AND client_id=0 OR type='plugin' AND element='contactcreator' AND folder='user' AND client_id=0 OR type='plugin' AND element='joomla' AND folder='user' AND client_id=0 OR type='plugin' AND element='profile' AND folder='user' AND client_id=0 OR type='plugin' AND element='joomla' AND folder='extension' AND client_id=0 OR type='plugin' AND element='joomla' AND folder='content' AND client_id=0 OR type='plugin' AND element='languagecode' AND folder='system' AND client_id=0 OR type='plugin' AND element='joomlaupdate' AND folder='quickicon' AND client_id=0 OR type='plugin' AND element='extensionupdate' AND folder='quickicon' AND client_id=0 OR type='plugin' AND element='recaptcha' AND folder='captcha' AND client_id=0 OR type='plugin' AND element='categories' AND folder='finder' AND client_id=0 OR type='plugin' AND element='contacts' AND folder='finder' AND client_id=0 OR type='plugin' AND element='content' AND folder='finder' AND client_id=0 OR type='plugin' AND element='newsfeeds' AND folder='finder' AND client_id=0 OR type='plugin' AND element='tags' AND folder='finder' AND client_id=0 OR type='plugin' AND element='totp' AND folder='twofactorauth' AND client_id=0 OR type='plugin' AND element='yubikey' AND folder='twofactorauth' AND client_id=0 OR type='plugin' AND element='nocaptcha' AND folder='captcha' AND client_id=0 OR type='template' AND element='beez3' AND folder='' AND client_id=0 OR type='template' AND element='hathor' AND folder='' AND client_id=1 OR type='template' AND element='protostar' AND folder='' AND client_id=0 OR type='template' AND element='isis' AND folder='' AND client_id=1 OR type='language' AND element='en-GB' AND folder='' AND client_id=0 OR type='language' AND element='en-GB' AND folder='' AND client_id=1 OR type='file' AND element='joomla' AND folder='' AND client_id=0
avatar brianteeman brianteeman - change - 3 Jan 2015
Status New Confirmed
avatar brianteeman brianteeman - change - 3 Jan 2015
Labels Added: ?
avatar zero-24 zero-24 - close - 14 Mar 2015
avatar zero-24 zero-24 - change - 14 Mar 2015
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2015-03-14 22:41:28
Closed_By zero-24
avatar zero-24 zero-24 - change - 14 Mar 2015
Closed_Date 2015-03-14 22:41:28 2015-03-14 22:41:29

Add a Comment

Login with GitHub to post a comment