Feeling Lucky
?
[#5316] - Removing unnecessary code from JModelAdmin
- Closed
- 4 Dec 2014
- Medium
- Build: staging
- # 5316
- Diff
- Hackwar:patch-17
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
I stumbled over this one during a code review. If this introduces any change, then we have bigger problems...
We are first checking if $this->type equals false. If that is the case, we create a new JUcmType object and get the type by alias. Then we do the same again, except that we assign the typeAlias. If $this->type does not equal false, we again assign the typeAlias. Long story short, double the code, always assigning $typeAlias => we can remove that part.
jissues-bot
- | Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-04 09:59:26 |
mbabker
- comment
- 4 Dec 2014
It looks like $typeAlias isn't even used in the method.
Bakual
- comment
- 4 Dec 2014
Indeed. Even $this->type isn't used as it looks.
Merged from review