Joomla! Issue Tracker | Joomla! CMS #5290 - Fix minor b/c break in https://github.com/joomla/joomla-cms/pull/4292

Closed
2 Dec 2014
Medium
Build: staging
# 5290
Diff
wilsonge:patch-27

Success

Success The Travis CI build passed Details

User tests: Successful: Unsuccessful:

wilsonge
2 Dec 2014

This fixes a minor b/c break in #4292 where in some cases you could get the InvalidArgumentException being thrown when you got a 303 message.

Cases involved passing in empty string or null as the message parameter meaning the check at https://github.com/joomla/joomla-cms/pull/4292/files#diff-11a160a70413114ea70faf547cd097ecR976 failed and these values became the moved parameter (and weren't booleans or integers).

This adds a unit test for that scenario and fixes it. Of course all of this relates to the old redirect method and so of course is deprecated.

2302a91 2 Dec 2014

Add test for legacy failure

a322a43 2 Dec 2014

Use a default of 303 instead of an exception

wilsonge - open - 2 Dec 2014

jissues-bot - change - 2 Dec 2014

Labels

Added: ?

JoomliC - comment - 2 Dec 2014

@test success!
Result : no B/C anymore.

beat - comment - 2 Dec 2014

@test success!
Same Result: No B/C anymore on redirects using old API (tested with CB installed from WebStore: 3.3.6 worked, master without patch fails, and with this PR it works again. Also tested other redirects in Joomla, and they still work (which was 100% certain looking at this PR).
Code-review is ok for me too. (y)

Thanks @wilsonge for your great improvement in com_redirect, and the library, and your quick addressing of this little B/C! Keep up your great work, Joomla needs people like you

JoomliC - comment - 2 Dec 2014

Thanks @wilsonge for your great improvement in com_redirect, and the library, and your quick addressing of this little B/C! Keep up your great work, Joomla needs people like you

The same as @beat : @wilsonge