? Error
Related to # 5185
Referenced as Related to: # 5185

User tests: Successful: Unsuccessful:

avatar alikon alikon - open - 25 Nov 2014
avatar jissues-bot jissues-bot - change - 25 Nov 2014
Labels Added: ?
avatar roland-d
roland-d - comment - 25 Nov 2014

@alikon We are touching the same file #5174. Something we need to take into consideration I think.

avatar alikon
alikon - comment - 25 Nov 2014

@roland-d yes but for different issues, i'm referring to this one #5185

avatar roland-d
roland-d - comment - 25 Nov 2014

@alikon I saw they are different, just more of a mental note for the mergers and us, whoever gets merged first will need to pull in the changes.

avatar waader
waader - comment - 25 Nov 2014

@test works

avatar brianteeman brianteeman - change - 25 Nov 2014
Category SQL
avatar brianteeman brianteeman - change - 25 Nov 2014
Rel_Number 5185
Relation Type Related to
avatar smanzi
smanzi - comment - 26 Nov 2014

@roland-d + @alikon Roland, as your PR #5174 has been merged, shouldn't Nicola now pull-in your your changes / rebase his branch?

avatar roland-d
roland-d - comment - 26 Nov 2014

That is correct, he has to pull in my changes.

avatar smanzi
smanzi - comment - 26 Nov 2014

OK, and... just to understand how to behave in such situation, would it be correct to do something like this in the git shell?

git checkout whatever_is_my_branch
git fetch upstream
git merge upstream/staging

Is that correct?

avatar roland-d
roland-d - comment - 26 Nov 2014

@smanzi I am not sure. Let's call in the troops. @Bakual @phproberto @mbabker can you confirm if that is correct?

avatar alikon
alikon - comment - 27 Nov 2014

When we have confirmation I'll need your help cause i'm a perfect github dumb

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5195.

avatar roland-d
roland-d - comment - 29 Nov 2014

@alikon An easier way to do this might be to simply replace the file in your branch with the current staging branch file and apply your change again. Just because it is such a small change.

avatar alikon
alikon - comment - 30 Nov 2014
avatar brianteeman
brianteeman - comment - 1 Dec 2014

Closed see #5260, #5261, #5262

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5195.

avatar brianteeman brianteeman - change - 1 Dec 2014
Status Pending Closed
avatar brianteeman brianteeman - close - 1 Dec 2014
avatar brianteeman brianteeman - change - 1 Dec 2014
Closed_Date 0000-00-00 00:00:00 2014-12-01 10:46:16

Add a Comment

Login with GitHub to post a comment