It doesn't work for me.

Here is how I tested it:

• Clicked add new menu item
• First I tried just to click save without filling out any info. The error says "Error Invalid field: Menu Item Type". Shouldn't it say first that the menu title is empty?
• Now I try to select the menu type and set it to "single article" and click save without selecting article or typing in a title. Now it says "Error Invalid form"
• If I then select an article and leave title blank, it still says "Invalid form"

So it seems like it needs a bit more tweaking :)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4755.

Tested unsuccessfully

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4755.

I submitted the form without having filled an field. The error message which appears is related to the second field ("invalid menu type") instead of the first field "menu title".
If I fill the field "menu type", the message is good.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4755.

can't see the failure. No differant after patching. Maybe you can describe the problem any further.
php 5.4.19, mysql 5.5.32 , j3.3.6

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4755.

Just updated the workflow and check condition. Please test it again.

@test
This works fine here.

@test
I have checked both with Hathor and Isis, and it is OK now

I have a doubt in this fix.
first:
formvalidator already add this message, so for fix it enough just remove a two line in item/tmpl/edit.php, that reset this message:

$('system-message').getElement('h4').innerHTML  = Joomla.JText._('ERROR');
$('system-message').getElement('div').innerHTML = Joomla.JText._('JGLOBAL_VALIDATION_FORM_FAILED');

second:
it already should be fixed in #4517

@Fedik
Last time, In process of this form, when you click on "Save" or "Save & Close" button, it's always check the "Menu Item Type" first --> So that, you always get message "Invalid Form" instead of "Invalid Field: Menu Item Title".

And I saw this comment
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_menus/views/item/tmpl/edit.php#L74
so that, I think this also use on another form by modal use. I keep this over there.

@thongredweb right,
First it check whether user just tries to set a menu type, in this step validation unnecessary.
Then if user want to save the form, so script do a form validation, and while validation the script add message of the validation result (if there any problem).
And if the form is invalid it execute all that in else block, where resets the messages to common text

I think this also use on another form by modal use

not by other form, it used by this form, for modal fields

Set to "closed" on behalf of @brianteeman by The JTracker Application at issues.joomla.org/joomla-cms/4755

This appears to have been resolved elsewhere as it is no longer an issue in 3.4alpha

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4755.