Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4752] - Fix: PHP undefined notice in caching file storage

? Success
Related to # 2535

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
17 Oct 2014

see: http://issues.joomla.org/tracker/joomla-cms/2535 & #2535

Steps to reproduce the issue

  1. configure caching to be file based in configuration.php
  2. use callback as handler
  3. lock the id
  4. remove the cache file
  5. unlock the id now

Expected result

If the cache file has beem removed, the unlock should just return true.

Actual result

Get php undefined variable notice:
Notice: Undefined variable: ret in web/libraries/joomla/cache/storage/file.php on line 333

System information (as much as possible)

Linux, Joomla 3.2 latest.

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
4.00
avatar zero-24 zero-24 - open - 17 Oct 2014
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Labels Added: ?
avatar zero-24 zero-24 - change - 17 Oct 2014
Category ⇒ Cache Libraries
avatar brianteeman brianteeman - change - 17 Oct 2014
Category Cache Libraries ⇒ Cache
avatar brianteeman brianteeman - change - 17 Oct 2014
Rel_Number ⇒ 2535
Relation Type ⇒ Related to
avatar zero-24
zero-24 - comment - 17 Oct 2014

hmm i have no clue why travis fail here?

There were 4 errors:
1) JResponseJsonTest::testSimpleSuccess
Exception: Application Instantiation Error
/home/travis/build/joomla/joomla-cms/libraries/joomla/factory.php:121
/home/travis/build/joomla/joomla-cms/libraries/cms/response/json.php:71
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/response/JResponseJsonTest.php:59
2) JResponseJsonTest::testSuccessWithData
Exception: Application Instantiation Error
/home/travis/build/joomla/joomla-cms/libraries/joomla/factory.php:121
/home/travis/build/joomla/joomla-cms/libraries/cms/response/json.php:71
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/response/JResponseJsonTest.php:79
3) JResponseJsonTest::testFailureWithException
Exception: Application Instantiation Error
/home/travis/build/joomla/joomla-cms/libraries/joomla/factory.php:121
/home/travis/build/joomla/joomla-cms/libraries/cms/response/json.php:71
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/response/JResponseJsonTest.php:100
4) JResponseJsonTest::testFailureWithData
Exception: Application Instantiation Error
/home/travis/build/joomla/joomla-cms/libraries/joomla/factory.php:121
/home/travis/build/joomla/joomla-cms/libraries/cms/response/json.php:71
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/response/JResponseJsonTest.php:124
avatar mbabker
mbabker - comment - 17 Oct 2014

Don't worry about it, already addressed. Refactored tests and a modified application reference in two separate patches at nearly the exact time made for an interesting followup.

avatar zero-24
zero-24 - comment - 17 Oct 2014

thanks @mbabker

avatar Hackwar
Hackwar - comment - 8 Dec 2014

@test successfull

avatar Hackwar Hackwar - test_item - 8 Dec 2014 - Tested successfully
avatar waader
waader - comment - 11 Dec 2014

@zero-24 I tried to follow the test instructions but I struggle already at the 2nd point. How do I use callback as handler. Do I have to write code to test this or can it be tested within the backend?

avatar zero-24 zero-24 - change - 11 Dec 2014
Milestone Added:
avatar zero-24 zero-24 - change - 20 Jan 2015
Category Cache ⇒ Cache Libraries
avatar zero-24 zero-24 - close - 31 May 2015
avatar zero-24 zero-24 - head_ref_deleted - 31 May 2015
avatar zero-24 zero-24 - change - 31 May 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-05-31 08:42:36
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 31 May 2015
avatar zero-24 zero-24 - head_ref_restored - 31 May 2015
avatar zero-24 zero-24 - reopen - 31 May 2015
avatar zero-24 zero-24 - change - 31 May 2015
Status Closed ⇒ New
Closed_Date 2015-05-31 08:42:36 ⇒
Closed_By zero-24 ⇒
avatar zero-24 zero-24 - reopen - 31 May 2015
avatar zero-24 zero-24 - change - 6 Jun 2015
Milestone Added:
avatar zero-24 zero-24 - change - 6 Jun 2015
Status New ⇒ Pending
avatar wilsonge wilsonge - reference | 92ca4ad - 17 Jun 15
avatar wilsonge wilsonge - merge - 17 Jun 2015
avatar wilsonge wilsonge - close - 17 Jun 2015
avatar wilsonge wilsonge - change - 17 Jun 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-06-17 20:33:29
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 17 Jun 2015
avatar zero-24 zero-24 - head_ref_deleted - 18 Jun 2015

Add a Comment

Login with GitHub to post a comment