Sorry you cant test your own stuff ;)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4718.

Alright :) Can I do something more with pull requests and issue description to make everyones life easier?

If you look at the diff it would appear you've broken all the spacing at the start of each line for implementation tho. Will try and get this tested properly tomorrow!

Do I create another pull request or is there a way to fix this here?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4718.

Just commit your fix to your branch (i.e. fix-issue-#4551) and it will automatically be applied to the pull request (which is for the whole branch).

@test, it works fine. As mentioned in file subtoolbar.php, the function JSubMenuHelper::addEntry() wil be deprecated in Joomla! 4.0 so we will use JHtmlSidebar::addEntry() instead.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4718.

@test, test OK - Navigation works fine.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4718.

Getting:

Fatal error: Class 'JToolBarHelper' not found in /var/www/html/pbf33/administrator/components/com_patchtester/views/pulls/view.html.php on line 119

when applying the patch. Checking ./administrator/includes/toolbar.php contains "400: Invalid request" so could be a problem with the patch tester or github.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4718.

I have applied the patch with Eclipse from github diff. I have been working with the applied patch with no issues so far.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4718.

The patchtester has been fixed, you can now use it to apply the PR. For me the fix is working so far!

Working also, and patch successfully tested.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4718.

Multiple successful tests - thanks - setting to RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4718.

@kirapwn Can you fix the codestyle issues?

FILE: /home/travis/build/joomla/joomla-cms/administrator/includes/toolbar.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 19 | ERROR | Missing class doc comment
--------------------------------------------------------------------------------

FILE: ...me/travis/build/joomla/joomla-cms/administrator/includes/subtoolbar.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 141 | ERROR | Please end your files with an empty line.
--------------------------------------------------------------------------------

I think they should be fixed now

You can see it by clicking on the cross/tick next to each commit like in the image above

Thanks.. guess I am blind

I have rebased and solved conflicts + small code style fixes in: #5149

Closing this.

Thanks @kirapwn for your contribution!