[#4694] - Disable cpanel and user menu when editing
- Closed
- 17 Oct 2014
- Medium
- Build: staging
- # 4694
- Diff
- dgt41:isis_ux
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Small UX improvement in ISIS template
What is it?
On ISIS when we are editing something (basically when we are in singular view) the main navigation becomes greyed out but cpanel and user menu are still visible. This PR hide them and removes their functionality.
Tests
Apply the patch and move around in the admin area
In pictures:
Normal view
Enter editing mode
Votes
jissues-bot
- | Labels |
Added:
?
|
||
nicksavov
- | Labels |
Added:
?
|
||
@brianteeman can you elaborate a little bit?
To explain further - in the past we have had proposals to hide buttons when
they cant be used and they were all rejected as being confusing (I dont
agree but that was the consensus)
For the toolbar buttons the only thing people wanted was to grey them out
if they are disabled but no one came up with a good way to do that with
bootstrap.
So following those decisions it is correct that the menu is displayed as
greyed out when disabled
On 16 October 2014 12:14, Brian Teeman brian@teeman.net wrote:
Sorry but I really dont like this
On 16 October 2014 11:44, Dimitri Grammatiko notifications@github.com
wrote:Small UX improvement in ISIS template What is it?
On ISIS when we are editing something (basically when we are in singular
view) the main navigation becomes greyed out, unavailable but still
visible. This PR hide it altogether. If you cannot click it don’t show it!
TestsApply the patch and move around in the admin area
In pictures:Normal view
[image: screenshot 2014-10-16 13 34 35]
https://cloud.githubusercontent.com/assets/3889375/4661252/56b0838c-5521-11e4-8ec0-545311a61367.pngEnter editing mode
[image: screenshot 2014-10-16 13 34 21]
https://cloud.githubusercontent.com/assets/3889375/4661254/5b831ec4-5521-11e4-84d4-5dba98de46a0.pngScrolling on editing mode
[image: screenshot 2014-10-16 13 34 11]https://cloud.githubusercontent.com/assets/3889375/4661260/6d587b30-5521-11e4-8ae2-6d6f9fea6b42.png
You can merge this Pull Request by running
git pull https://github.com/dgt41/joomla-cms isis_ux
Or view, comment on, or merge it at:
#4694
Commit Summary
- Remove disabled navigation
File Changes
- M administrator/templates/isis/index.php https://github.com/joomla/joomla-cms/pull/4694/files#diff-0 (22)
Patch Links:
- https://github.com/joomla/joomla-cms/pull/4694.patch
- https://github.com/joomla/joomla-cms/pull/4694.diff
—
Reply to this email directly or view it on GitHub
#4694.Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
This is not about hiding/disabling buttons, it’s about hiding the navigation. And from my point of view having something that is just taking space in the screen is not a good UX. Also another big thing is that when you enter the edit mode you should not have options to click on anything that will unintentionally exit the editing without first warning you so. As it is now the template when you are in editing mode you still have the joomla icon, the shortcut to the site and the cog icon which all of them, when clicked will not warn you that you will actually LOOSE everything you just altered.
I disagree with Brian that it is not confusing when buttons disappear completely, but totally agree with his "I really don't like this". PhpStorm (random example) works like that: The menu adjusts dynamically to available options. Driving me crazy. Looking for a menu item that was there a minute ago. If it's greyed out, I know it's probably for a good reason. If it's gone, I don't know if it's a bug, or if I'm looking in the wrong place. But since there's already a widely accepted consensus - do we need to discuss this here?
@lausianne 3 things:
PHPstorm’s dynamically menus is totally different animal.
Before you disagree I thing you should try, you might be surprised!
Form follows function is a nice motto. In our case if there is no function there shouldn’t be any form.
This is an interesting idea. I do support the general concept of removing unusable elements from the page, but do have some concern about a consistent user experience and losing context.
I'm undecided at the moment, but would be interested to also hear the thoughts of folks like @CristinaSolana, @nternetinspired, @phproberto and others.
@dgt41 phpstorm is just one example of software where unusable elements disappear completely, and this causes problems.
What exactly should I try?
Disabled buttons totally do have a function. To know that there is a button, but currently (in the current context) you can't use it. The form is, it greyes out. If it has no function ever, then it should never be there ... of course.
My $0.02?
Primary navigation is a fundamental anchor for user experience. It's a fixed point that, like the constellations of stars above us, should be consistent, predictable and reliable if it is to be trusted and relied upon. I don't think it's ever good for users to hide it.
We already have a complex UI (parameters for example). "Losing context" (as Matt says) is not what we want.
-1 from me.
It also removes some active stuff (cpanel, user menu, frontpage link).
Judging from other comments, there is a big vote against this change. I'm closing it.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-16 13:36:58 |
I think I have to explain the purpose of this PR which is:
to DISABLE (by hiding navigation because this is the easiest approach here) links that are irrelevant when someone is editing something and thus PREVENTING THE LOSS of any alterations already done.
The other option will be to totally redesign back end so those links are not available in the first place.
@infograf768 I will try again… disabling and not hidding this time
very elegantly put @nternetinspired I will have to remember that one
| Status | Closed | ⇒ | New |
Reopened as requested 
Can you update the screenshots in the description then?
@infograf768 That was too fast to be true. Now should be ok, please try again!
| Title |
|
||||||
@test successful
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4694.
| Title |
|
||||||
| Status | New | ⇒ | Ready to Commit |
Two good tests setting to RTC
@brianteeman @infograf768 I just saw that the if statement in the scroll function is totally useless so I removed it. Sorry about that. Needs tests again
| Category | ⇒ | Templates (admin) UI/UX |
| Status | Ready to Commit | ⇒ | Pending |
Set back to pending
Tests reverted
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4694.
Travis failure is not related to this
1) JAdministratorHelperTest::testFindOptionCanLoginAdminOptionSet
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'foo'
+’com_login’
Ya, that was my bad, it's fixed already.
The "Registration Date" have not splited to date and time yet.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4694.
In left menu in user manager, don't show button remove.
what about this ... it doesn't disable cpanel when i wrote new email :D
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4694.
@test
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4694.
rahultomar
- 
missing the ID area in User name window
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4694.
@trangredweb This pull request is only disabling the cpanel and user menu on the views where the menubar is already disabled. If you think it should be disabled n other views please create a new issue
@vanredweb did you mean to post that here - it doesnt seem to be related to this isse
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4694.
icon for button "Hide the sidebar" should change.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4694.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 2014-10-16 13:36:58 | ⇒ | 2014-10-17 08:16:11 |
| Milestone | |||
@tairedweb please check #4788
@infograf768 disable the menubar in com_messages edit #4788
| Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
Sorry but I really dont like this
On 16 October 2014 11:44, Dimitri Grammatiko notifications@github.com
wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/