@test OK

@Fedik can you fix the merge conflicts here? I will test after a resync to be sure that nothing is broken Thanks!

@zero-24 done

and I added strict mode, so please retest

Thanks @Fedik

@test successful I can't see any issues with the patch applyed.

and I added strict mode, so please retest
@Fedik do @anibalsanchez also retest or can we move it now to RTC?

yes, would be good to retest

@anibalsanchez can you please try one more time?

... hmmm ... I have manually copied the two files... In Global Configuration, I try to save an empty Site Name, it shows the message "Invalid field: Site Name"... Cancel button does not work.

@anibalsanchez I just checked without the patch, and got same result as you,
so I think it is not a regression that made by this pull request ....
looks like you found some bug in global configuration page

yes it on the configuration page,
there test for task == "application.cancel" but must be task == "config.cancel.application" on first look

@Fedik do you think we should fix this with this pull or should we open a new for this issue?

@Fedik You are right here: cancel button has <button onclick="Joomla.submitbutton('config.cancel.application')" class="btn btn-small">

and the script we inject is :

    Joomla.submitbutton = function(task)
    {
        if (task == "application.cancel" || document.formvalidator.isValid(document.getElementById("application-form")))
        {
            Joomla.submitform(task, document.getElementById("application-form"));
        }
    };

@zero-24 I think would be better separate as it is different things .. I can try make another pull with fix, but at evening

@zero-24 would be better separate as it is different things .. I can try make another pull with fix, but at evening

Thanks moving here to RTC as the other issue will be handled in a seperate PR by @Fedik Thanks to all!

@test success
before time = 1.004 ms

After time = 0.734 ms

there fix for cancel button #5738