Thanks for submitting this, Shur! :)

The code looks good.

It's all code styling improvements, with the additions of the following two options for the postinstall_messages table:
IF NOT EXISTS
ENGINE=InnoDB

Looks like Travis is failing on the above two changes, so the unit tests would have to be updated appropriately.

@nicksavov Those failures are pre-existing and have been for several weeks now.

Ah, OK, cool. Thanks!

RTC

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

I don't know why my PR causes the Travis CI build mistake.
Is there any actions from my side expected to have this PR accepted?

There are some codestyle issues. You can see them at the bottom of https://travis-ci.org/joomla/joomla-cms/jobs/34492664. It would be great if you can fix those.

The failed unit tests itself are because we use a deprecated method in the tests. It hasn't anything to do with your PR. To fix that, you could rebase your PR with staging, if you know how to do that. Otherwise don't bother.

@Bakual This PR touches only one SQL file, so the code style errors are already present in the branch...

True, interesting :)

@Bakual

you could rebase your PR with staging

see the same PR in staging: #4311
and for Joomla 2.5 #4300

This PR is not updated since the weblinks removal was updated in 3.4-dev.

@shur can you update/rebase it?

Thanks!

@phproberto
Frankly speaking I'm not sure how to rebase correctly.
But I made another PR #4311 that has all the changes from the current PR and much more changes. And that PR is associated to staging.

Probably the current PR can be closed, if PR #4311 is accepted.

@shur thanks but as this will be merged into v3.4 the PR has to be done against the 3.4-dev branch. You have to checkout that branch and then do your changes.

@phproberto

You have to checkout that branch and then do your changes.

I've compared these changes to the current joomla.sql from 3.4-dev.
This PR makes no sense now because all changes are already implemented by my another staging PR #4298

So I close it.