adding in cc: @kshitijSharma2014 and @puneet0191 so we can evaluate, because the sample data is used in system tests.

If accepted I will remove the extra language strings from all the
installation language files if needed

On 3 September 2014 14:36, javier gomez notifications@github.com wrote:

adding in cc: @kshitijSharma2014 https://github.com/kshitijSharma2014
and @puneet0191 https://github.com/puneet0191 so we can evaluate,
because the sample data is used in system tests.

—
Reply to this email directly or view it on GitHub
#4213 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

It's actually the only sample data I use, but I agree it is hard to maintain and will have to changed/removed anyway with the removal of weblinks and other extensions.

Yes its useful for the people who will read what I write here but thats
about it So let it be gone

On 3 September 2014 19:53, Thomas Hunziker notifications@github.com wrote:

It's actually the only sample data I use, but I agree it is hard to
maintain and will have to changed/removed anyway with the removal of
weblinks and other extensions.

—
Reply to this email directly or view it on GitHub
#4213 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Tested successfully. Please do not merge until @javigomez confirms it's ok.

Maybe we can look at creating a standalone sample data install just for
testers

On 3 September 2014 23:56, Roberto Segura notifications@github.com wrote:

Tested successfully. Please do not merge until @javigomez
https://github.com/javigomez confirms it's ok.

—
Reply to this email directly or view it on GitHub
#4213 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

But we would still need to maintain it.

If we cannot avoid to maintain it maybe we can keep the sample_testing option on the installation but download the sample data on demand. We save > 1MB on the package doing it on demand.

In fact we could do that with all the sample data ( > 2,5 MB ) or just keep a single package to allow a basic install offline. That would allow us to create more sample data online (like update servers) without modifying the installer + adding KB.

Yes we would need to maintain it but as its distributed to such small set
its not that important

On demand sample files is something I would love to work towards in the
future

On 4 September 2014 00:11, Roberto Segura notifications@github.com wrote:

But we would still need to maintain it.

If we cannot avoid to maintain it maybe we can keep the sample_testing
option on the installation but download the sample data on demand. We save

1MB on the package doing it on demand.

In fact we could do that with all the sample data ( > 2,5 MB ) or just
keep a single package to allow a basic install offline. That would allow us
to create more sample data online (like update servers) without modifying
the installer + adding KB.

—
Reply to this email directly or view it on GitHub
#4213 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

It may become a good usecase for a "testing" distro.

for now lets make all our lives easier and remove it from the default
installation

On 4 September 2014 10:17, Thomas Hunziker notifications@github.com wrote:

It may become a good usecase for a "testing" distro.

—
Reply to this email directly or view it on GitHub
#4213 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

This will ruin all the selenium tests. Because it checks the sorting ordering of data by checking for items in a given row. I agree that this is the right option. But we will need to work out what to do with those tests

Yes, It would affect a lot of tests..but this year we tried to remove the row dependent assertions with Assert greater than..I think It can be handled :)

@brianteeman
Let's keep the language strings in. They do no harm and will be useful if we re-instate the testing Sample data. Also, some installation ini do contain extra customised strings for localised sample datas including test.
I do consider though that this test sample data has been a real asset for JBS + anyone not formally in JBS but testing patches.

On 5 September 2014 11:38, infograf768 notifications@github.com wrote:

@brianteeman https://github.com/brianteeman
Let's keep the language strings in. They do no harm and will be useful if
we re-instate the testing Sample data. Also, some installation ini do
contain extra customised strings for localised sample datas including test.

Unfortunately that wont work as from what I can tell if the string is there then the option is there

I do consider though that this test sample data has been a real asset for
JBS + anyone not formally in JBS but testing patches.

It has been but for the reasons outlined before I still believe it is
better to remove it from the core

—
Reply to this email directly or view it on GitHub
#4213 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Unfortunately that wont work as from what I can tell if the string is there then the option is there

Weird as it depends on the presence of the file as far as I know. See:

// Build the options list from the list of files.
        if (is_array($files))
        {
            foreach ($files as $file)
            {
                $options[] = JHtml::_('select.option', $file, $lang->hasKey($key = 'INSTL_' . ($file = JFile::stripExt($file)) . '_SET') ?
                    JHtml::_('tooltip', JText::_('INSTL_' . strtoupper($file = JFile::stripExt($file)) . '_SET_DESC'), '', '',
                        JText::_('INSTL_' . ($file = JFile::stripExt($file)) . '_SET')
                    ) : $file
                );
            }
        }

My mistake - putting the unused language strings back then

On 5 September 2014 12:00, infograf768 notifications@github.com wrote:

Unfortunately that wont work as from what I can tell if the string is
there then the option is there

Weird as it depends on the presence of the file as far as I know. See:

// Build the options list from the list of files.
if (is_array($files))
{
foreach ($files as $file)
{
$options[] = JHtml::('select.option', $file, $lang->hasKey($key = 'INSTL' . ($file = JFile::stripExt($file)) . 'SET') ?
JHtml::('tooltip', JText::('INSTL' . strtoupper($file = JFile::stripExt($file)) . 'SET_DESC'), '', '',
JText::('INSTL_' . ($file = JFile::stripExt($file)) . '_SET')
) : $file
);
}
}

—
Reply to this email directly or view it on GitHub
#4213 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@test OK,

Just downloaded and installed https://github.com/brianteeman/joomla-cms/archive/removetest.zip

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4213.

@test I did the same as anibalsanchez and it worked.

One note aside: when I updated this version from J3.3.4-dev to J3.3.7-dev I got this error:
0 Database query failed (error # %s): %s SQL=INSERT INTO "d7rx1_update_sites" ("name", "type", "location", "enabled") VALUES ('Joomla! Update Component Update Site', 'extension', 'http://update.joomla.org/core/extensions/com_joomlaupdate.xml', 1);