Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4144] - Fix ineffecient queries: OR => IN

? Success

User tests: Successful: Unsuccessful:

avatar nonumber
nonumber
22 Aug 2014

This PR fixes the places where multiple ORs are used instead on an IN.
So instead of doing:
WHERE id = 1 OR id = 3 OR id = 5
it should be:
WHERE id IN (1, 3, 5)

Using IN vs OR:

  • Uses less code (as in: query code passed to database object)
  • Easier to maintain
  • Easier to understand
  • And most importantly: IN is 2 - 3 times faster than OR (depending on indexes, how many ORs, etc)

Testing Instructions

Test the affected components if they still work ok (admin and frontend):

  • com_banners
  • com_finder
  • com_users
  • com_weblinks

If possible, also test if there are any negative differences with SQLServer and PostgreSQL.

avatar nonumber nonumber - open - 22 Aug 2014
avatar jissues-bot jissues-bot - change - 22 Aug 2014
Status Pending ⇒ New
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-08-22 07:29:46
Labels Added: ?
avatar jissues-bot jissues-bot - close - 22 Aug 2014
avatar nonumber nonumber - change - 22 Aug 2014
Status New ⇒ Closed
avatar nonumber nonumber - close - 22 Aug 2014
avatar nonumber nonumber - close - 22 Aug 2014
avatar nonumber nonumber - change - 22 Aug 2014
Status Closed ⇒ New
avatar nonumber nonumber - reopen - 22 Aug 2014
avatar nonumber nonumber - reopen - 22 Aug 2014
avatar infograf768 infograf768 - change - 22 Aug 2014
Status New ⇒ Pending
avatar beat
beat - comment - 22 Aug 2014

:+1: from a code-review point of view as well as MySQL performance point of view all good, makes sense. Thanks Peter! :smile:

avatar nonumber
nonumber - comment - 20 Sep 2014

Been lying around for 4 weeks now. So no interest = close.

avatar nonumber nonumber - close - 20 Sep 2014
avatar nonumber nonumber - change - 20 Sep 2014
Status Pending ⇒ Closed
Closed_Date 2014-08-22 07:29:46 ⇒ 2014-09-20 13:04:39

Add a Comment

Login with GitHub to post a comment