User tests: Successful: Unsuccessful:
I believe that it should either be an option or always setup that the image also links to the article just like the title and readmore. In the blog layout I watch my clients always rolling over the intro image first to click on it to see the full article. I do this to all my sites as it seems to be a better UX.
(This is my 2nd :-) try at contributing to Joomla. Please tell help me if I am doing this wrong. I am not a coder, but was able to get this to work for my client's site by copy/pasting similar code.)
Status | Pending | ⇒ | New |
Labels |
Added:
?
?
|
Labels |
Added:
?
|
Agreed. I have edited the code in my environment, but due to lack of github experience I don't know what to do next. Please help so I can paste in the new edits.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-20 19:26:50 |
Status | Closed | ⇒ | New |
If you're using the GitHub UI, then you can edit the file again in your browser and do the changes. This pull request will be updated with the changes then.
You just need to make sure you select the correct branch (patch-2
) in your forked repo. Or just use this link and click the edit button there: https://github.com/modernmagic/joomla-cms/blob/patch-2/layouts/joomla/content/intro_image.php
If you need help, just ask. I'm happy to help.
After applying patch (patchtester), intro image still was not linked. Tried cutting and pasting the code directly from https://github.com/modernmagic/joomla-cms/blob/patch-2/layouts/joomla/content/intro_image.php into layouts/joomla/content/intro_image.php with no success either.
Joomla 3.3.4dev
XAMPP 3.2.1
Windows7 (virtualized)
This is the first time I've done this in a while, so I feel pretty new at this. Please let me know if there is anything else needed.
Labels |
Removed:
?
|
A couple of months ago I posted the same request:
http://issues.joomla.org/tracker/joomla-cms/3178
I also added a pull request:
lausianne@bdd6b41#commitcomment-7485539
... but apparently it's not working anymore. If someone else is working on this now, I'll leave it alone.
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
I am using this code in Joomla 3.3.3
What would need to be changed for 3.3.4 ?
Patch works fine for me.
However I see some codestyle issues I would like to have resolved first.
I'm going to add some notice to the diff so you see what I mean.
@sonkoral On which page did you try this? I used a blog menu item where it worked. There may be other layouts which don't use the JLayout to show the intro_image. There it would not work.
The category should make no difference at all. It always uses the same layout. Maybe something is cached?
DOH! Cleared cache and browser -- now works perfectly. Noob error.
Labels |
Added:
?
|
Marked RTC as we have two good tests.
Merged into 3.4-dev
branch. Thanks!
Status | New | ⇒ | Closed |
Closed_Date | 2014-08-20 19:26:50 | ⇒ | 2014-08-31 18:07:54 |
Was that intended to be a separate PR or why do you think you messed it up? It looked fine to me.
Since there was no activity and I titled it the same, I thought it might have been skipped over. Again, I'm new to github so I'm not sure I did it right. —
Jeff Mayland
modernmagic.com
On Sun, Aug 31, 2014 at 1:06 PM, Thomas Hunziker notifications@github.com
wrote:
Was that intended to be a separate PR or why do you think you messed it up? It looked fine to me.
Reply to this email directly or view it on GitHub:
#4134 (comment)
Looks all fine
It's working fine but when using caption text then the image in not more linked.
Hey modernmagic, thanks for the quick reply.
It doesn't work for joomla 3.3.1.
I had to updated to 3.3.3, and now everything works, and with caption text also! :)
If we want to add this, I guess the logic for the link should match the one used for the title. Similar to what is done in the JLayout for the blog title: https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/content/blog_style_default_item_title.php#L23.
So only link the image if the parameter to link the title is enabled and the user is allowed to see the full article.