Looks good from a quick review of the file changes. How can this be manually tested? Does https://github.com/joomla/joomla-cms/blob/staging/tests/unit/suites/libraries/joomla/microdata/JMicrodataTest.php need updating?

@betweenbrain The types.json file doesn't have any test. Even if the https://github.com/joomla/joomla-cms/blob/staging/tests/unit/suites/libraries/joomla/microdata/JMicrodataTest.php file has a lot of changes, almost all of them are english language errors, + a new test was added to fix the bug (a logic bug). You think more tests need to be added?

Hello @PAlexcom

Thank you for your contribution.

The last comment here was on 16th August 2014. So the question is, Is this issue/pull request still valid?
if so please provide clear test instructions to be able to test / reproduce this issue.
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!

Hi @roland-d, this PR is still valid, I can't provide test instructions to test / reproduce this issue simply because this PR contains some code refactoring/bug fix (with tests)/update of the JMicrodata library, the PR can be merged.

Hello @PAlexcom the bug fix should be reproducible or not? I see that some kind off fallback mechanism has changed, shouldn't that be testable? The code is touched somewhere or not?

@PAlexcom Can you provide feedback on my questions?

Merged based on review. Library is not used in core itself.

@PAlexcom Nice and usefull piece of code, the JMicrodata class. Thanks.
I started these days to implement microdata in some extensions, but there are differences between schema.org and the types.json file.

I found some missing properties (Event->workPerformed) and expected porperty-types (PostalAddress->addressCountry can be Text too, not only type 'Country')

To avoid hardcoding - where can I get the most recent types.json-file? Should I use your Spider4Schema for that?

@roland-d I really apologize for not replying in time, I see now that the PR was merged, it should not break anything and update the new schema, to be honest two years have passed: I do not remember exactly what bug the PR fixes, but I can investigate if needed.

@peterpeter Thanks & sorry for the late reply ;)

I started these days to implement microdata in some extensions, but there are differences between schema.org and the types.json file.

That is because the types.json file is an older version, a new PR should be done in order to update the file.

To avoid hardcoding - where can I get the most recent types.json-file? Should I use your Spider4Schema for that?

Yes, Spider4Schema is the spider/parser that creates the types.json file, however I'm not sure if it still works properly since schema.org have changed their website recently.

@alexprut I understand you don't remember when it's such an old PR. It is already in Joomla 3.5.0 so it's OK. At least it did go in :)

I hardly dare to ask but could you do a new PR with the updates types.json file? Put me in there as well so I am aware of it. Thank you.

@roland-d I'll try do my best to update the file asap.

@alexprut Thanks, we are here all weekend working on the issue tracker, if you can get it done we will merge it this weekend for sure.