Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#38471] - [5.2] Drone: Adding check for PHP version

? ? Composer Dependency Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
16 Aug 2022

Right now we actually aren't checking the compatibility of our code for a certain PHP version statically. This PR should change that.

avatar Hackwar Hackwar - open - 16 Aug 2022
avatar Hackwar Hackwar - change - 16 Aug 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2022
Category ⇒ External Library Composer Change
avatar Hackwar Hackwar - change - 16 Aug 2022
Labels Added: Composer Dependency Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2022
Category External Library Composer Change ⇒ Unit Tests External Library Composer Change
avatar Hackwar Hackwar - change - 18 Aug 2022
Labels Added: ?
avatar Hackwar
Hackwar - comment - 18 Aug 2022

When PRs #38528 and #38527 are merged, the hard errors would be solved in our codebase. The issues left would be several warnings and 3 errors regarding soft reserved keywords which we are using. Those issues couldn't be solved and should be part of the exclusion list.

avatar HLeithner
HLeithner - comment - 6 Sep 2022

@Hackwar what can we do here? clean the error or mark as exception for phpcs?

avatar Hackwar
Hackwar - comment - 6 Sep 2022

Most of these should be fixed. Some would have to be marked as exclusions. Will look at that soon.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2022
Category External Library Composer Change Unit Tests ⇒ Unit Tests Administration com_joomlaupdate Language & Strings External Library Composer Change Installation Libraries
avatar Hackwar Hackwar - change - 6 Sep 2022
Labels Added: Language Change
avatar Hackwar Hackwar - change - 7 Sep 2022
Title
…
[4.2] Drone: Adding check for PHP version
[4.3] Drone: Adding check for PHP version
avatar Hackwar Hackwar - edited - 7 Sep 2022
avatar joomla-cms-bot joomla-cms-bot - change - 7 Sep 2022
Category External Library Composer Change Unit Tests Administration com_joomlaupdate Language & Strings Installation Libraries ⇒ Unit Tests Repository Administration com_associations com_banners com_categories com_config com_contact com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_languages com_menus
avatar joomla-cms-bot joomla-cms-bot - change - 7 Sep 2022
Category Unit Tests Administration com_joomlaupdate Repository com_associations com_banners com_categories com_config com_contact com_content com_contenthistory com_fields com_finder com_installer com_languages com_menus ⇒ Unit Tests Repository Administration com_banners com_categories com_contact com_content com_cpanel com_fields com_finder com_joomlaupdate com_languages com_media com_menus com_modules com_newsfeeds com_redirect com_tags com_templates
avatar Hackwar Hackwar - change - 13 Sep 2022
Labels Added: PR-4.3-dev
Removed: Language Change Composer Dependency Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2022
Category Unit Tests Administration com_joomlaupdate Repository com_banners com_categories com_contact com_content com_fields com_finder com_languages com_menus com_cpanel com_media com_modules com_newsfeeds com_redirect com_tags com_templates ⇒ Unit Tests Administration com_joomlaupdate Language & Strings External Library Composer Change Installation Libraries
avatar Hackwar Hackwar - change - 13 Sep 2022
Labels Added: Language Change Composer Dependency Changed
avatar Hackwar
Hackwar - comment - 13 Sep 2022

This needs a thorough code review. All changes are outdated code which we never removed.

avatar laoneo
laoneo - comment - 24 Sep 2022

Either this needs to be split into chunks with propper teating instructions or rebased to 5.0 and merged there early. But I wouldn't merge this in a minor only by code review.

avatar joomla-cms-bot joomla-cms-bot - change - 22 Oct 2022
Category Unit Tests Administration com_joomlaupdate Language & Strings External Library Composer Change Installation Libraries ⇒ Unit Tests Administration com_joomlaupdate com_templates Language & Strings External Library Composer Change Installation Libraries
avatar HLeithner
HLeithner - comment - 22 Oct 2022

Please proper error handling using error_get_last() like used in the framework package and rebase on j5.

avatar HLeithner
HLeithner - comment - 23 Oct 2022

@Hackwar can you solve the merge conflicts please

avatar Hackwar
Hackwar - comment - 24 Oct 2022

I've split this PR up into 5 PRs, see above. When those are merged and they are upmerged into this branch, that should leave only the code to introduce the version check in phpcs. I don't think it is usefull to solve the conflicts before those are merged, since each will introduce new conflicts...

avatar joomla-cms-bot joomla-cms-bot - change - 8 Mar 2023
Category Unit Tests Administration com_joomlaupdate Language & Strings External Library Composer Change Installation Libraries com_templates ⇒ Unit Tests External Library Composer Change Libraries
avatar Hackwar Hackwar - change - 8 Mar 2023
Labels Added: PR-5.0-dev
Removed: Language Change
avatar HLeithner HLeithner - change - 8 Mar 2023
Title
…
[4.3] Drone: Adding check for PHP version
[5.0] Drone: Adding check for PHP version
avatar HLeithner HLeithner - edited - 8 Mar 2023
avatar Hackwar Hackwar - change - 7 Apr 2023
Labels Added: ?
Removed: PR-4.3-dev
avatar Hackwar Hackwar - change - 18 Apr 2023
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-04-18 12:06:27
Closed_By ⇒ Hackwar
avatar Hackwar Hackwar - close - 18 Apr 2023
avatar Hackwar Hackwar - change - 18 Apr 2023
Status Closed ⇒ New
Closed_Date 2023-04-18 12:06:27 ⇒
Closed_By Hackwar ⇒
avatar Hackwar Hackwar - change - 18 Apr 2023
Status New ⇒ Pending
avatar Hackwar Hackwar - reopen - 18 Apr 2023
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
…
[5.0] Drone: Adding check for PHP version
[5.2] Drone: Adding check for PHP version
avatar HLeithner HLeithner - edited - 24 Apr 2024

Add a Comment

Login with GitHub to post a comment