Feeling Lucky
?
[#3710] - Fix broken captcha and use class
- Closed
- 2 Jun 2014
- Medium
- Build: staging
- # 3710
- Diff
- wilsonge:patch-6
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Captcha was broken by this commit: acb7e30
which reversed the order of id and class for code style. To fix this i've given class a default empty string value and used it in the method
wilsonge
- comment
- 2 Jun 2014
Sure. Although if you're using the JCaptcha class - which is the recommended thing to do - this automatic (see https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/captcha/captcha.php#L170)
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-06-02 19:23:29 |
Can you add to the doc block for the
$classparam that the string needs to be passed asclass="required", not like one would assume just the class itself?Then that part should be clear to anyone.
Beside that I fully support that fix.