? ? Success
Referenced as Related to: # 5543

User tests: Successful: Unsuccessful:

avatar AshanFernando
AshanFernando
18 Sep 2013

Under GSoC MooTools to jQuery project, this PR removes the MooTools dependencies in beez3 template folder

Feature Tracker Item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32034&start=575

avatar AshanFernando AshanFernando - open - 18 Sep 2013
avatar 810
810 - comment - 20 Dec 2013

There are +2 tests, so i think it can be merged.

avatar brianteeman brianteeman - change - 8 Aug 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 2 Sep 2014
Category JavaScript Template
avatar RCheesley
RCheesley - comment - 18 Oct 2014

Test info from JoomlaCode:

Removing MooTools dependencies from templates/beez3/ folder by converting it to jQuery and JavaScript.
Branch: https://github.com/AshanFernando/joomla-cms/tree/gsoc-mootools-jquery-usertemplates
Pull Request: #2002

Test:
Go to Extensions->Template Manager from administrator section. Change default Site template to Beez3. The site template should work for mobile size views(Menu Item Change) and other functionalities should work without errors.

Applied patch, enabled Beez3, site appears to work fine in regular & mobile resolutions.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2002.

avatar RCheesley RCheesley - test_item - 18 Oct 2014 - Tested successfully
avatar Hackwar
Hackwar - comment - 17 Nov 2014

Could you please update your branch to the latest version of staging and you will encounter a few issues regarding codestyle, afaics. If that part is done, I think this can be merged directly. It's actually a shame that this has not been merged earlier...

avatar AshanFernando
AshanFernando - comment - 17 Nov 2014

@Hackwa Ok will do... !

avatar AshanFernando AshanFernando - change - 18 Nov 2014
Title
Removing MooTools dependencies from beez3 template
[#32034] Removing MooTools dependencies from beez3 template
avatar AshanFernando
AshanFernando - comment - 18 Nov 2014

@Test After resolving the conflicts, tested this on Chrome (Mobile mode with Nexus 5) using the breez3 template and simulated menu open and close which worked as expected.

avatar anibalsanchez
anibalsanchez - comment - 24 Dec 2014

@test OK, in desktop and mobile (Tested creating weblink)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2002.
avatar anibalsanchez anibalsanchez - test_item - 24 Dec 2014 - Tested successfully
avatar wilsonge
wilsonge - comment - 27 Dec 2014

@AshanFernando I can't apply this patch in git. Sorry to be a pain but would you please resubmit it against the current staging branch and I'll straight merge it with the tests from there as long as all the commits are the same :)

avatar AshanFernando
AshanFernando - comment - 27 Dec 2014

@wilsonge Done :)
Link to the PR joomla-projects#268

avatar Hackwar
Hackwar - comment - 27 Dec 2014

that is the wrong project...

avatar Hackwar
Hackwar - comment - 27 Dec 2014

you need to apply that against joomla/joomla-cms and the staging branch.

avatar AshanFernando
AshanFernando - comment - 28 Dec 2014

@Hackwar Thanks for the correction.. I have created a new PR
#5543

avatar wilsonge
wilsonge - comment - 28 Dec 2014

Thanks Ashan! Closing this one in favour of the new one!

avatar wilsonge wilsonge - close - 28 Dec 2014
avatar wilsonge wilsonge - change - 28 Dec 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-12-28 15:57:12

Add a Comment

Login with GitHub to post a comment