• Applied patch
• Updated composer composer update
• Run php libraries/vendor/phpunit/phpunit/phpunit tests/unit/suites/libraries/joomla/cache
• All unit tests passed and no more php 7.0 Cache_Lite deprecated notice (that existed before this patch)

I have tested this item ✅ successfully on f5c9b36

as comments above

This can't be merged. Their repo's composer.json manifest is incorrect. If you look at the PEAR package manifest, in the changelog for the release they indicate bumping to a PHP 5.4 minimum. Also see #10835 (comment)

changelog for the release they indicate bumping to a PHP 5.4 minimum

michael what's the impact of that? Unit tests on Cache_Lite don't run in php 5.3 ?

I don't know how Composer handles it, but if our composer.lock file were correctly updated with this change and someone on a PHP 5.3 environment tried to run composer install they would potentially get a message about being unable to install all dependencies. If that happened the entire PHP 5.3 build would fail.

If we want to test Cache_Lite 1.8 we'll need a conditional step in the Travis build sequence to update it on-the-fly before running the tests.

IMHO No. This PR only remove notice on php7.

i don't know much about composer but isn't it possible to add a separate config for php version in unit tests?
like (note this is just a wild guess)

  "config": {
    "platform": {
      "php": "5.3.10"
    },
    "platform-dev": {
      "php": "5.4"
    },

The config key doesn't have a platform-dev key, see https://getcomposer.org/doc/06-config.md

ok thanks michael for the explaining

After updating the lock file the PHP 5.3 build doesn't error out, this is most likely because as I pointed out their composer.json manifest is incorrect (it still declares PHP 4.0 as minimum though the PEAR channel declares different).

Still can't say I'm comfortable with that though as the package author has explicitly declared dropping PHP 5.3 support which we are still supporting.

Then for the moment I have to close it.

I have checked changes in cache_lite code at https://github.com/pear/Cache_Lite
and the is no reason to bump php version to 5.4 for now, may be later author want to add incompatibility changes.

I close it.

can't this go for 4.0-dev (which is php 5.5+) branch now ?

Good point:)

I have rebased my PR to 4.0-dev branch, but it is probably not enough.

Fixed.

I downloaded composer from https://getcomposer.org/download/
and run as you mentioned but using local version:

$ php composer.phar -V
Composer version 1.2.1 2016-09-12 11:27:19

If changes in libraries/vendor/composer/ClassLoader.php can not be merged then I can try again with composer 1.2.0.

Looks fine, hadn't realized 1.2.1 released. The important part was using
at least 1.2.0 since we have the static loader files it generates already
and I didn't want the whole thing to get out of sync along the way.

On Thursday, September 22, 2016, Tomasz Narloch notifications@github.com
wrote:

I downloaded composer from https://getcomposer.org/download/
and run as you mentioned but using local version:

$ php composer.phar -V
Composer version 1.2.1 2016-09-12 11:27:19

If changes in libraries/vendor/composer/ClassLoader.php can not be merged
then I can try again with composer 1.2.0.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11884 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoRTbhGkKjCBvmTdim03GlTfYhgYoks5qsnUOgaJpZM4Jzj-A
.

@mbabker can you approve the changes than? (else we get the red X in the PR) 😄

They need to make that possible via the mobile interface...

I agree 👍