[#11881] - [database] Remove the defaulting to the root account in mysql & mysqli
- Fixed in Code Base
- 2 Sep 2016
- Medium
- Build: staging
- # 11881
- Diff
- zero-24:default_root
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 5 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11878
Summary of Changes
There is no need to default to root as no public webserver should allow access via root and empty pw.
Also no other cms database class defaults to root if it is not set. they just default to empty.
Testing Instructions
- Install Joomla using this package: https://github.com/zero-24/joomla-cms/archive/default_root.zip
- make sure the install works
- navigate to the backend and freontend
- meke sure they work too.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Labels |
Added:
?
|
||||||
| Title |
|
||||||
tested on
- PHP Built On Windows NT ALIKON-PC 6.1 build 7601 (Windows 7 Professional Edition Service Pack 1) i586
- Database Version 5.5.5-10.1.8-MariaDB-log
- Database Collation utf8_general_ci
- Database Connection Collation utf8mb4_general_ci
- PHP Version 5.5.30
- Web Server Apache/2.4.17 (Win32) OpenSSL/1.0.2d PHP/5.5.30
and still able to install with user:root and an empty psw (as is quite common default config for tools like XAMPP)
Maybe we remove localhost also?
in this case maybe we need to change too
This is usually "localhost".
to
Either something as "localhost" or a hostname given by the host.
or something similar i guess
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11881.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11881.
I have tested this item
I have tested this item successfully
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11881.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11881.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11881.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11881.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-02 11:17:31 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Maybe we remove localhost also?