Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
8 Dec 2013

Per #115, this lists out all packages for the Framework we're actually depending on. Since we're using so much of it, Composer is still installing the full Framework, but this better gauges what we are actually using. I've also removed the use of the Framework's Event and Log packages (Event was actually unused totally aside from loading the dispatcher and Log replaced with our using Monolog).

Other dependencies are updated as well with the composer update

avatar mbabker mbabker - open - 8 Dec 2013
avatar drmmr763 drmmr763 - reference | - 9 Dec 13
avatar b2z
b2z - comment - 9 Dec 2013

:+1:

avatar elkuku
elkuku - comment - 9 Dec 2013

Isn't DI a separate package ?
Filesystem is used in the CLI app, but that could (or should) be refactored to use DirectoryIterators.
The with() method lives in the PHP package.

Otherwise: Big :+1:

avatar elkuku elkuku - reference | - 12 Dec 13
avatar elkuku elkuku - merge - 12 Dec 2013
avatar elkuku elkuku - close - 12 Dec 2013
avatar elkuku elkuku - change - 12 Dec 2013
Status New Closed
Closed_Date 0000-00-00 00:00:00 2013-12-12 13:43:34
avatar elkuku elkuku - close - 12 Dec 2013
avatar elkuku
elkuku - comment - 12 Dec 2013

I think we need to figure out what to do if we need a dev-master version of any of the framework packages - and I'm pretty sure we will...

Until then, this will look good when we release our 1.0 :wink:

avatar elkuku elkuku - head_ref_deleted - 12 Dec 2013
avatar elkuku
elkuku - comment - 12 Dec 2013

I switched the joomla/github package to dev-master, did a clean install with the following result:

  - Installing joomla/framework (1.0)
    Loading from cache

  - Installing joomla/joomla-framework (dev-master 1e5c9a1)
    Cloning 1e5c9a192167d285da30b705157ffa7eb0649811

autoload_namespaces.php

'Joomla' => 
array(
$baseDir . '/src', $vendorDir . '/joomla/framework/src', 
$vendorDir . '/joomla/joomla-framework/src'),

Files

├── vendor
│   ├── joomla
│   │   ├── framework
│   │   └── joomla-framework

pretty messy I guess...

avatar b2z
b2z - comment - 12 Dec 2013

Hmm @eddieajau or @dongilbert can comment on this? ;)

avatar dongilbert
dongilbert - comment - 12 Dec 2013

Composer dependency resolution within our packages is messed up somewhere. Should be fixed soon with the release of 1.1. We've added some new features and fixed some things. I think it warrants an update.

Add a Comment

Login with GitHub to post a comment