User tests: Successful: Unsuccessful:
At the moment the custom fields are in the submenu for contact. With this PR The two submenu items are moved to the main menu like in the other extensions.
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql com_contact Modules Installation |
I have tested this item
Tested successfully. We shouldd really merge in the testing sample data plugin and drop the SQL files.
Status | Pending | ⇒ | Ready to Commit |
RTC
Title |
|
Title |
|
Labels |
Added:
?
?
|
can you fix the conflicts please
Labels |
Removed:
J4 Issue
|
@bembelimen can you fix the conflicts please and then we can get this merged
Status | Ready to Commit | ⇒ | Pending |
Removing rtc until conflicts are fixed. Mainly just to avoid me re-reading this PR every 2 weeks when I go through the RTC pile. Whenever they are fixed someone can mark this back as RTC
@bembelimen please can you fix the conflicts
I tried to test this with the view to resolving the conflicts and submitting it as a new pr but it is not a correct PR or the code required has changed since this was created
disable/enable custom fields for contact to check display/hide
This had no effect
The separator between contacts and fields is not rendered correctly
<li class="divider" role="presentation"><a class="no-dropdown" href="#"><span class="sidebar-item-title"></span></a></li>
Should be
<li class="divider" role="presentation"><span></span></li>
Otherwise it becomes a clickable and focusable item
Please resolve conflicting files so this PR can get tested at Worldwide Pizza, Bugs & Fun, October 19th
Found the reason that
disable/enable custom fields for contact to check display/hide did not work
The value for the component_id in the sql was 33 - it should be the id of the com_fields component in the extensions table which is 30
@bembelimen has obviously abandoned this important PR so if one of the sql gurus could create a new pr that would be awesome and then people will be able to create fields for com_contacts again
cc / @alikon @richard67 @Quy
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-08 04:13:11 |
Closed_By | ⇒ | Quy |
I have tested this item✅ successfully on 1846d32
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23366.