User tests: Successful: Unsuccessful:
Pull Request for Issue #23345 .
Confirm Password field removed from user edit in backend
code review or test whether user edit forks as expected and Confirm Password is not present.
No Confirm Password field and user edit works.
Confirm Password field exists and user edit works
no
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_users Language & Strings |
Why would you want to do this? For BC you should at least add it as a config option which is showing both by default.
The second password is only wasted time and no longer up to date in modern apps (my opinion).
I do not insist but why then do we have the new password with the "plain text" button?
If it is a B/C problem, we need a param and or a solution for the password2 check. But I do not see a big B/C problem. The password2 is not in the database. It could be used in extensions of the registration form, but I am sure that there we can find a solution.
Labels |
Added:
?
?
|
Category | Administration com_users Language & Strings | ⇒ | Administration com_admin com_users Language & Strings Front End Libraries |
I don't see the reason for this change
should at least add it as a config option
Please NO more switches...
I have tested and it looks great. But in the confirm.xml still is a password2. Could you remove this too?
It is components\com_users\forms\reset_complete.xml
I have tested this item
Thank you @wojsmol
Category | Administration com_users Language & Strings com_admin Front End Libraries | ⇒ | Administration com_admin com_users Front End Libraries |
Thinking about this, if we proceed with it... what about showing the password rather than hiding by default so people can see if it's typed correctly?
@tonypartridge the password shouldn't be visible by default and also in the field (password) was added a button to reveal the text just for this scenario. FWIW the field still needs to become a custom element, there used to be a PR by me and would be really nice if someone resurrects it because the current code is not production-ready...
I have tested this item
The file marked for modification does not exist: administrator/components/com_admin/Model/ProfileModel.php
I have tested this item
Works not for me as well:
The file marked for modification does not exist: administrator/components/com_admin/Model/ProfileModel.php
PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
This really should be closed do people don't waste their time
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 13:53:38 |
Closed_By | ⇒ | Quy |
Category | Administration com_users com_admin Front End Libraries | ⇒ | Administration com_admin com_users Language & Strings Front End Libraries |
Hi guys,
PHP 8.1.x + Joomla 5.x.
I understand what @dgrammatiko wrote 5 years ago about to don't create another setting, but, from my point of view this is a good case to add an option to use / not use the Password2 confirmation field on both, the Registration page and the Profile Edit.
It is time to reconsider this PR, In the last 5 years a lot of things have changed:
I would add to the reasons written above into the previous users messages:
Do you agree?
I see that the password is removed from the user edit view.
But there are about 30 places where the password2 is used in the code.
It is checked in the models and appears in different views and models in the frontend.
So I think it is too early for submitting a test result.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23357.